Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date-picker: year picker does not display when loaded on phone #2033

Open
DavidAkkerman opened this issue Jan 13, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@DavidAkkerman
Copy link
Contributor

Current behavior

When the year picker is loaded on a phone screen, it works as a normal date-picker instead:
MicrosoftTeams-image (2)

When it loads on a big screen, the year picker works as expected:
2023-01-13 14_20_37-Window

Steps to reproduce the behavior:

  1. Set your browser in phone mode,visit https://lundalogik.github.io/lime-elements/versions/36.1.0/#/component/limel-date-picker/ and scroll down to Year

Expected behavior

Environment

  • lime-elements version: 36.1.0-next.30
@DavidAkkerman DavidAkkerman added the bug Something isn't working label Jan 13, 2023
@adrianschmidt
Copy link
Contributor

This is because browsers don't have native pickers for year-only, and several other types of "dates" we support. Rather than risking that our custom picker might not work well on certain phones, we fall back to using the native picker. The date is treated the same though. It should not matter which date in a year you select. Once the field is blurred, it ought to only show the selected year.

I know this isn't optimal, and it might be the case that the custom picker would give a better user experience after all.

We could potentially add an option to force the use of custom or native picker… 🤔

@Kiarokh Kiarokh moved this to All Open Issues in Prioritisation board Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: All Open Issues
Development

No branches or pull requests

2 participants