fix: Change initialization order #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LumaKernel
changed the title
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
tani
added a commit
to tani/vim-tsdetect
that referenced
this pull request
Oct 12, 2022
LumaKernel
pushed a commit
that referenced
this pull request
Oct 12, 2022
* Change initialization order * Suppress autocmds errors * Suppress tsdetect#coc#auto#switch#*#after * Revert #10 * format code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7. This PR moves the single line from L27 to L57.
L27 executed
runtime plugin/tsdetect.vim. Then, Vim runs the auto commandUser tsdetect#detect. However, before L27, Vim has not defined such auto commands. In fact, the function initialize() first defined those auto commands. By moving it to L57, Vim throws no errors mentioned in #7. It seems no problem because there are no suspicious codes between L27 to L57 (there are only the registration commands for Coc.nvim). I hope that it works well.