Skip to content

Update stylelint + format code with Stylistic #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: rc
Choose a base branch
from
Open

Update stylelint + format code with Stylistic #4039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e47272d
chore(stylelint): Remove useless package and update package-lock.json…
fbasmaison-lucca Oct 27, 2025
ca43713
chore(stylelint): Upgrade stylelint and stylelint-config-standard-scss.
fbasmaison-lucca Oct 27, 2025
54b72b7
chore(stylelint): Address `scss/operator-no-unspaced` rule.
fbasmaison-lucca Oct 27, 2025
b4e854b
chore(stylelint): Address `scss/at-if-closing-brace-newline-after` rule.
fbasmaison-lucca Oct 27, 2025
98569af
chore(stylelint): Address `scss/operator-no-newline-after`:
fbasmaison-lucca Oct 27, 2025
8ed89f1
chore(stylelint): Address `property-no-deprecated`.
fbasmaison-lucca Oct 27, 2025
156c0c2
chore(stylelint): Address `no-invalid-position-declaration`.
fbasmaison-lucca Oct 27, 2025
e7f2f45
chore(stylelint): Address `nesting-selector-no-missing-scoping-root`.
fbasmaison-lucca Oct 27, 2025
ace8a4c
chore(stylelint): Address `block-no-redundant-nested-style-rules`.
fbasmaison-lucca Oct 28, 2025
26b227e
feat(stylelint): Use Stylistic to format code:
fbasmaison-lucca Oct 28, 2025
7750865
chore(stylelint): Format lines (autofix).
fbasmaison-lucca Oct 28, 2025
8b6c209
chore(stylelint): Fix spaces vs tabs:
fbasmaison-lucca Oct 28, 2025
a6997af
chore(stylelint): Format grid areas.
fbasmaison-lucca Oct 27, 2025
6ae3fa3
chore(stylelint): Format selectors.
fbasmaison-lucca Oct 28, 2025
9e372db
chore(stylelint): Format blocks.
fbasmaison-lucca Oct 28, 2025
94e1ded
chore(stylelint): Format declarations.
fbasmaison-lucca Oct 28, 2025
edd88e5
chore(stylelint): Format strings.
fbasmaison-lucca Oct 28, 2025
1166947
chore(stylelint): Format numbers.
fbasmaison-lucca Oct 28, 2025
3620de1
chore(stylelint): Format functions.
fbasmaison-lucca Oct 28, 2025
154dfc8
chore(stylelint): Format colours.
fbasmaison-lucca Oct 28, 2025
afc697c
fix(stylelint): Revert previous change to avoid mixed content:
fbasmaison-lucca Oct 28, 2025
e6c75fa
fix stylelistic in packages
mbriand-lucca Oct 28, 2025
d30d916
Merge branch 'rc' into linting/stylelint-as-formatter-rc
fbasmaison-lucca Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,075 changes: 2,340 additions & 735 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
"@storybook/addon-docs": "^9.0.15",
"@storybook/angular": "^9.0.15",
"@storybook/test-runner": "^0.23.0",
"@stylistic/stylelint-config": "^3.0.1",
"@testing-library/angular": "^17.4.0",
"@testing-library/dom": "^10.4.0",
"@testing-library/jest-dom": "^6.6.3",
Expand Down Expand Up @@ -114,7 +115,7 @@
"prettier": "^3.5.1",
"sass": "^1.62.1",
"storybook": "^9.0.15",
"stylelint": "^16.23.1",
"stylelint": "^16.25.0",
"ts-node": "~10.9.1",
"typescript": "5.8.3",
"typescript-eslint": "^8.33.1"
Expand Down
1 change: 1 addition & 0 deletions packages/icons/src/commons/base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

@if config.$isNamespaced {
@layer base {
// stylelint-disable-next-line block-no-redundant-nested-style-rules, nesting-selector-no-missing-scoping-root -- & references the selector calling this mixin.
& {
-moz-osx-font-smoothing: grayscale;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/icons/src/commons/core.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
$index: string.index($string, $search);

@if $index {
@return string.slice($string, 1, $index - 1) + $replace +
replace(string.slice($string, $index + string.length($search)), $search, $replace);
@return string.slice($string, 1, $index - 1) + $replace
+ replace(string.slice($string, $index + string.length($search)), $search, $replace);
}

@return $string;
Expand Down
2 changes: 1 addition & 1 deletion packages/icons/src/commons/utils/icon.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
-webkit-font-smoothing: antialiased;
text-transform: none;
} @else {
@error "“#{$name}” wasn’t found in “@lucca-front/icons config.$icons” map.";
@error '“#{$name}” wasn’t found in “@lucca-front/icons config.$icons” map.';
}
}
2 changes: 1 addition & 1 deletion packages/icons/src/icon/component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ $defaultAtRoot: config.$isNamespaced and 'with: rule' or 'without: rule';
text-transform: none;
vertical-align: text-bottom;
white-space: nowrap;
word-wrap: normal;
overflow-wrap: normal;

&::before {
content: var(--icon-content) / '';
Expand Down
1 change: 0 additions & 1 deletion packages/ng/app-layout/app-layout.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
@use '@lucca-front/scss/src/components/appLayout';

2 changes: 1 addition & 1 deletion packages/ng/button/button.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
@use '@lucca-front/scss/src/components/button';
@use '@lucca-front/scss/src/components/button';
2 changes: 1 addition & 1 deletion packages/ng/callout/callout-feedback-item/callout-feedback-item.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
@use '@lucca-front/scss/src/components/calloutFeedbackList';
@use '@lucca-front/scss/src/components/calloutFeedbackList';
2 changes: 1 addition & 1 deletion packages/ng/callout/callout-feedback-list/callout-feedback-list.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
@use '@lucca-front/scss/src/components/calloutFeedbackList';
@use '@lucca-front/scss/src/components/calloutFeedbackList';
1 change: 0 additions & 1 deletion packages/ng/container/container.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
@use '@lucca-front/scss/src/components/container';

2 changes: 1 addition & 1 deletion packages/ng/forms/rich-text-input/plugins/link/link.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.linkPopover{
.linkPopover {
display: flex;
justify-items: center;
gap: var(--pr-t-spacings-50);
Expand Down
1 change: 0 additions & 1 deletion packages/ng/main-layout/main-layout.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
@use '@lucca-front/scss/src/components/mainLayout';

6 changes: 4 additions & 2 deletions packages/ng/multi-select/input/select-all/multi-select-all-header.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,16 @@
}

@layer mods {
&:hover, :host-context(.is-highlighted) & {
&:hover,
:host-context(.is-highlighted) & {
background-color: var(--palettes-neutral-50);
}

&:has(.checkboxField-input:checked) {
background-color: var(--palettes-50, var(--palettes-product-50));

&:hover, :host-context(.is-highlighted) & {
&:hover,
:host-context(.is-highlighted) & {
background-color: var(--palettes-100, var(--palettes-product-100));
}
}
Expand Down
5 changes: 4 additions & 1 deletion packages/ng/multi-select/panel/panel.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use "@lucca-front/scss/src/components/button/exports" as button;
@use '@lucca-front/scss/src/components/button/exports' as button;

.optionItem-groupKey {
@layer components {
Expand All @@ -19,9 +19,12 @@
@include button.block;
@include button.ghost;

// stylelint-disable block-no-redundant-nested-style-rules -- Prevent issues with mixed declarations.
// SEE: https://sass-lang.com/documentation/breaking-changes/mixed-decls/
& {
justify-content: left;
}
// stylelint-enable

&.is-highlighted {
--components-button-color: var(--palettes-700, var(--palettes-neutral-700));
Expand Down
4 changes: 2 additions & 2 deletions packages/ng/numeric-badge/numeric-badge.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@use "@lucca-front/scss/src/components/numericBadge";
@use '@lucca-front/scss/src/components/numericBadge';

lu-numeric-badge {
@layer base {
display: inline-flex;
display: inline-flex;
}
}
5 changes: 4 additions & 1 deletion packages/ng/simple-select/panel/panel.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use "@lucca-front/scss/src/components/button/exports" as button;
@use '@lucca-front/scss/src/components/button/exports' as button;
@use 'definitions';

@include definitions.optionSearcherStyle;
Expand All @@ -11,9 +11,12 @@
@include button.block;
@include button.ghost;

// stylelint-disable block-no-redundant-nested-style-rules -- Prevent issues with mixed declarations.
// SEE: https://sass-lang.com/documentation/breaking-changes/mixed-decls/
& {
justify-content: left;
}
// stylelint-enable
}

@layer mods {
Expand Down
1 change: 0 additions & 1 deletion packages/ng/styles/components/cdk/_dragDrop.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,3 @@
transition: transform 250ms cubic-bezier(0, 0, 0.2, 1);
}
}

1 change: 0 additions & 1 deletion packages/ng/styles/components/cdk/_global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@

@include overflow.scrollblock('!important');
}

3 changes: 1 addition & 2 deletions packages/ng/styles/components/cdk/_misc.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.cdk-visually-hidden {
border: 0 !important;
clip: rect(1px, 1px, 1px, 1px) !important;
clip-path: rect(1px, 1px, 1px, 1px) !important;
block-size: 1px !important;
inline-size: 1px !important;
margin: -1px !important;
Expand All @@ -10,4 +10,3 @@
white-space: nowrap !important;
contain: paint !important;
}

1 change: 0 additions & 1 deletion packages/ng/styles/components/cdk/_textarea.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,3 @@
padding-inline: 0 !important;
box-sizing: content-box !important;
}

6 changes: 4 additions & 2 deletions packages/ng/styles/definitions/option/_option-item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@
}

@layer mods {
&.is-selected, :host-context([aria-selected="true"]) & {
&.is-selected,
:host-context([aria-selected='true']) & {
background-color: var(--palettes-50, var(--palettes-product-50));

&::before {
Expand Down Expand Up @@ -171,7 +172,8 @@
inline-size: var(--components-options-checkbox-size);
}

&.is-selected, :host-context([aria-selected="true"]) & {
&.is-selected,
:host-context([aria-selected='true']) & {
&::before {
background-color: var(--components-options-checkbox-color);
box-shadow: inset 0 0 0 2px var(--components-options-checkbox-color);
Expand Down
2 changes: 1 addition & 1 deletion packages/ng/styles/definitions/select/_select-input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
// ▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒

@layer mods {
// Small
// Small
:host-context(.textfield.mod-S) {
padding: 0;

Expand Down
2 changes: 1 addition & 1 deletion packages/ng/time/duration-picker/duration-picker.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

@layer base {
lu-duration-picker {
display: inline-flex;
display: inline-flex;
}
}
2 changes: 1 addition & 1 deletion packages/ng/time/time-picker/time-picker.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

@layer base {
lu-time-picker {
display: inline-flex;
display: inline-flex;
}
}
6 changes: 4 additions & 2 deletions packages/ng/tree-select/tree-branch/tree-branch.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
opacity: 0;
}

.optionItem.is-highlighted, .optionItem-value:hover {
.optionItem.is-highlighted,
.optionItem-value:hover {
.optionItem-icons {
opacity: 1;
}
Expand All @@ -28,7 +29,8 @@
--components-options-item-multiple-padding: calc(1.75rem + var(--pr-t-spacings-100) * var(--components-treeBranch-level));

.optionItem-value {
&::before, &::after {
&::before,
&::after {
inset-inline-start: calc(var(--pr-t-spacings-100) * var(--components-treeBranch-level));
}
}
Expand Down
4 changes: 3 additions & 1 deletion packages/scss/src/commons/base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
}

@if config.$isNamespaced {
// stylelint-disable-next-line block-no-redundant-nested-style-rules -- & references the selector calling this mixin.
& {
@include body;
@include html;
Expand Down Expand Up @@ -99,7 +100,8 @@
}
}

button, button[type] {
button,
button[type] {
text-rendering: inherit;

&:focus-visible {
Expand Down
34 changes: 15 additions & 19 deletions packages/scss/src/commons/config.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ $borderRadiusTokens: (
'input': var(--pr-t-border-radius-default),
);


$product: 'brand' !default;
$palettesShades: text, 0, 25, 50, 100, 200, 300, 400, 500, 600, 700, 800, 900; // text is deprecated
$palettesStates: 'critical', 'error', 'warning', 'success', 'successContrasted', 'warningContrasted';
Expand Down Expand Up @@ -141,8 +140,8 @@ $fieldsWidth: 20, 30, 40, 50, 60 !default;
// Palettes

$ai: (
500: #BC6FDD,
600: #A440CF,
500: #bc6fdd,
600: #a440cf,
);

$brand: (
Expand Down Expand Up @@ -351,17 +350,17 @@ $warning: (
$warningContrasted: (
// text is deprecated
text: #ffffff,
0: #FFFFFF,
50: #FFF2DB,
100: #FFE9C2,
200: #FFDB9E,
300: #FFD080,
400: #FFC35C,
500: #FFB13D,
0: #ffffff,
50: #fff2db,
100: #ffe9c2,
200: #ffdb9e,
300: #ffd080,
400: #ffc35c,
500: #ffb13d,
600: #d97e26,
700: #B34B0F,
800: #9A3B08,
900: #802A00
700: #b34b0f,
800: #9a3b08,
900: #802a00
);

$critical: (
Expand Down Expand Up @@ -595,13 +594,10 @@ $elevation: (
'backdrop': color-mix(in srgb, var(--palettes-neutral-400) 40%, transparent),
),
shadow: (
'raised':
'0 0 0 1px color-mix(in srgb, var(--palettes-neutral-400) 8%, transparent), 0 1px 2px color-mix(in srgb, var(--palettes-neutral-400) 40%, transparent), 0 2px 4px color-mix(in srgb, var(--palettes-neutral-400) 20%, transparent)',
'raised': '0 0 0 1px color-mix(in srgb, var(--palettes-neutral-400) 8%, transparent), 0 1px 2px color-mix(in srgb, var(--palettes-neutral-400) 40%, transparent), 0 2px 4px color-mix(in srgb, var(--palettes-neutral-400) 20%, transparent)',
'button': '0 2px 2px 0 color-mix(in srgb, var(--palettes-neutral-900) 4%, transparent)',
'overflow':
'0 0 0 1px color-mix(in srgb, var(--palettes-neutral-400) 8%, transparent), 0 0 4px color-mix(in srgb, var(--palettes-neutral-400) 32%, transparent), 0 0 8px color-mix(in srgb, var(--palettes-neutral-400) 24%, transparent)',
'overlay':
'0 0 0 1px color-mix(in srgb, var(--palettes-neutral-400) 8%, transparent), 0 4px 8px color-mix(in srgb, var(--palettes-neutral-400) 24%, transparent), 0 4px 12px 2px color-mix(in srgb, var(--palettes-neutral-400) 8%, transparent)',
'overflow': '0 0 0 1px color-mix(in srgb, var(--palettes-neutral-400) 8%, transparent), 0 0 4px color-mix(in srgb, var(--palettes-neutral-400) 32%, transparent), 0 0 8px color-mix(in srgb, var(--palettes-neutral-400) 24%, transparent)',
'overlay': '0 0 0 1px color-mix(in srgb, var(--palettes-neutral-400) 8%, transparent), 0 4px 8px color-mix(in srgb, var(--palettes-neutral-400) 24%, transparent), 0 4px 12px 2px color-mix(in srgb, var(--palettes-neutral-400) 8%, transparent)',
),
);

Expand Down
2 changes: 1 addition & 1 deletion packages/scss/src/commons/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use "sass:meta";
@use 'sass:meta';
@use '@lucca-front/scss/src/commons/utils/namespace';
@use 'exports' as *;

Expand Down
2 changes: 1 addition & 1 deletion packages/scss/src/commons/utils/a11y.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@mixin mask($suffix: '') {
border: 0 #{$suffix};
clip: rect(1px, 1px, 1px, 1px) #{$suffix};
clip-path: rect(1px, 1px, 1px, 1px) #{$suffix};
margin: -1px #{$suffix};
overflow: hidden #{$suffix};
padding: 0 #{$suffix};
Expand Down
3 changes: 0 additions & 3 deletions packages/scss/src/commons/utils/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,6 @@
}
}



[data-content-before] {
&::before {
content: attr(data-content-before);
Expand Down Expand Up @@ -669,7 +667,6 @@
@extend %fontFamilyBrand;
}


@each $display in core.$displays {
@if $display != 'none' {
.u-onlyPrintDisplay#{transform.capitalize(transform.camelize($display))} {
Expand Down
1 change: 1 addition & 0 deletions packages/scss/src/commons/utils/namespace.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ $defaultAtRoot: 'without: rule';

@mixin appendRootVars {
@if config.$isNamespaced {
// stylelint-disable-next-line block-no-redundant-nested-style-rules -- & references the selector calling this mixin.
& {
@content;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/scss/src/commons/utils/overflow.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

&::-webkit-scrollbar {
display: none #{$suffix};
}
}
}

@mixin scrollblock($suffix: '') {
overflow: hidden #{$suffix};

&,
body {
touch-action: none #{$suffix};
Expand Down
Loading