Skip to content

Update stylelint + format code with Stylistic #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: rc
Choose a base branch
from
Open

Update stylelint + format code with Stylistic #4039

wants to merge 23 commits into from
+2,994 −1,239

Conversation

@fbasmaison-lucca
Copy link
Contributor

@fbasmaison-lucca fbasmaison-lucca commented Oct 28, 2025 •
edited
Loading

Description

  • Update Stylelint and default config.
  • Remove useless stylelint-config-prettier-scss package. Formatting rules have been removed from Stylelint in v16.
  • Add Stylistic to format code.
  • Fix or address violations.

Occurrences of // stylelint-disable @stylistic/indentation are waiting for this fix.

@fbasmaison-lucca
chore(stylelint): Remove useless package and update package-lock.json…
e47272d 
Formatting rules have been removed from Stylelint in v15.
@fbasmaison-lucca
chore(stylelint): Upgrade stylelint and stylelint-config-standard-scss.
ca43713
@fbasmaison-lucca
chore(stylelint): Address scss/operator-no-unspaced rule.
54b72b7
@fbasmaison-lucca
chore(stylelint): Address scss/at-if-closing-brace-newline-after rule.
b4e854b
@fbasmaison-lucca
chore(stylelint): Address scss/operator-no-newline-after:
98569af 
Disable `scss/operator-no-newline-before` to allow having operators at the start of the line, which makes logical combination more legible with long lines.
@fbasmaison-lucca
chore(stylelint): Address property-no-deprecated.
8ed89f1
@fbasmaison-lucca
chore(stylelint): Address no-invalid-position-declaration.
156c0c2
@fbasmaison-lucca
chore(stylelint): Address nesting-selector-no-missing-scoping-root.
e7f2f45
@fbasmaison-lucca
chore(stylelint): Address block-no-redundant-nested-style-rules.
ace8a4c
@fbasmaison-lucca
feat(stylelint): Use Stylistic to format code:
26b227e 
Prettier is too JS-centric and not adapted to potential quirks in SCSS declarations.
@c-3po c-3po bot added the 📖 Documentation changes Requires a Prisme update label Oct 28, 2025
@fbasmaison-lucca fbasmaison-lucca force-pushed the linting/stylelint-as-formatter-rc branch from 0a6dd35 to 154dfc8 Compare October 28, 2025 11:10
@fbasmaison-lucca fbasmaison-lucca force-pushed the linting/stylelint-as-formatter-rc branch 2 times, most recently from 8b908dc to afc697c Compare October 28, 2025 16:16
@LuccaIntegration
Copy link

LuccaIntegration commented Oct 28, 2025

👩‍🍳 https://lucca-front.lucca.tech/PR-4039/storybook

@CCNET-iLucca
Copy link

CCNET-iLucca commented Oct 28, 2025

Tests d'interfaces

@fbasmaison-lucca fbasmaison-lucca marked this pull request as ready for review October 31, 2025 09:35
@fbasmaison-lucca fbasmaison-lucca requested review from a team as code owners October 31, 2025 09:35
@jeremie-lucca jeremie-lucca added this to the 21.0 milestone Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

📖 Documentation changes Requires a Prisme update

Projects

None yet

Milestone

21.0

Development

Successfully merging this pull request may close these issues.

6 participants

@fbasmaison-lucca @LuccaIntegration @CCNET-iLucca @jeremie-lucca @mbriand-lucca