Skip to content

add tips about addon manager #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2024
Merged

add tips about addon manager #25

merged 3 commits into from
Feb 10, 2024

Conversation

KeilAwk
Copy link
Contributor

@KeilAwk KeilAwk commented Feb 6, 2024

like title,I added some hints about git fetch failure and publishing addons to LLS-Addons

i am not sure that need this change, but if not, let me know and I'll turn off this pr

Copy link
Collaborator

@carsakiller carsakiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the warning about needing a connection to GitHub could be helpful, I think it just needs to be more succinct.

@carsakiller carsakiller added the wiki/tweak A small fix, like grammar or typo. label Feb 7, 2024
Co-authored-by: carsakiller <carsakiller@gmail.com>
@KeilAwk KeilAwk requested a review from carsakiller February 9, 2024 15:06
Co-authored-by: carsakiller <carsakiller@gmail.com>
@KeilAwk
Copy link
Contributor Author

KeilAwk commented Feb 10, 2024

sorry it looks like that i ignored something
now i commited this change

@carsakiller carsakiller merged commit 0fa4e31 into LuaLS:main Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wiki/tweak A small fix, like grammar or typo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants