From dd70edf25cc447610dc12df370c5c614cf5b5c95 Mon Sep 17 00:00:00 2001 From: Abdelrahman Ashraf Date: Mon, 26 Aug 2024 19:53:06 +0700 Subject: [PATCH] =?UTF-8?q?fix(web):=20=F0=9F=90=9B=20incorrect=20default?= =?UTF-8?q?=20dpr=20(#338)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix(web): 🐛 incorrect default dpr * chore: 🤖 update changelog --- .changeset/green-coins-relate.md | 5 +++++ packages/web/src/utils.ts | 2 +- packages/web/tests/utils.test.ts | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/green-coins-relate.md diff --git a/.changeset/green-coins-relate.md b/.changeset/green-coins-relate.md new file mode 100644 index 00000000..40375d1e --- /dev/null +++ b/.changeset/green-coins-relate.md @@ -0,0 +1,5 @@ +--- +'@lottiefiles/dotlottie-web': patch +--- + +fix(web): 🐛 incorrect default dpr diff --git a/packages/web/src/utils.ts b/packages/web/src/utils.ts index e3c4a0e8..32264158 100644 --- a/packages/web/src/utils.ts +++ b/packages/web/src/utils.ts @@ -55,5 +55,5 @@ export function isLottie(fileData: string | Record): boolean { export function getDefaultDPR(): number { const dpr = IS_BROWSER ? window.devicePixelRatio : 1; - return (1 + (dpr - 1)) * DEFAULT_DPR_FACTOR; + return 1 + (dpr - 1) * DEFAULT_DPR_FACTOR; } diff --git a/packages/web/tests/utils.test.ts b/packages/web/tests/utils.test.ts index fd7c1450..1d04baf4 100644 --- a/packages/web/tests/utils.test.ts +++ b/packages/web/tests/utils.test.ts @@ -91,6 +91,6 @@ describe('isLottie', () => { describe('getDefaultDotLottieDPR', () => { test('return 75% of device pixel ratio', () => { - expect(getDefaultDPR()).toBe((1 + ((window.devicePixelRatio || 1) - 1)) * 0.75); + expect(getDefaultDPR()).toBe(1 + (window.devicePixelRatio - 1) * 0.75); }); });