Validate repository secrets #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gestrich, these open PRs would probably be good to go ahead and review/merge. |
MikePlante1
pushed a commit
to MikePlante1/LoopCaregiver
that referenced
this pull request
Jun 7, 2023
Update NightscoutChartView.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on LoopWorkspace #36, this adds rudimentary support for validation of repository secrets used in GitHub Actions + Fastlane build workflows.
A shared validate_secrets.yml has been added as a dependency of the other workflows to validate secrets prior to adding identifiers, creating certificates, or building LoopCaregiver. It can also be run independently via standard workflow dispatch.
The workflow should be pretty self-explanatory, but each required repository secret is checked to verify that it is set and non-empty, then secondary validation is done upon the GH_PAT (via the GitHub CLI client) to ensure write permissions on the Match-Secrets repository and FASTLANE_ secrets (via a new validate_secrets lane) to ensure that an App Store Connect API authorization with the repository secrets is successful.