-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Pumpmanager changes #877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Pumpmanager changes #877
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
36a2a53
Omnikit
ps2 5746df1
Add OmniKit frameworks
ps2 6988bb8
fix cartfile
ps2 1b23177
Track lastAddedPumpData, including lastAddedPumpEvents
ps2 6b4544c
Fix carthage copy frameworks script
ps2 5e9f41a
rebase
ps2 096b347
update deps
ps2 65e3c9e
Initialize setupViewController with existing pump settings
ps2 2ee5feb
Suspend/Resume
ps2 ad73ea8
Use normal separator behavior
ps2 230a441
Reload pump section after adding pumpmanager
ps2 83f2943
LoopKit PumpManagerStatus updates
ps2 ff978b4
Merge in dev
ps2 d0c4a91
PumpManagerUI vended HUD views
ps2 b2a68e0
Add missing file
ps2 63932d1
Update to LoopKit naming changes
ps2 8524093
Push instead of present pumpmanager vended vc in response to HUD view…
ps2 37ef4aa
Add prep_workspace.sh script
ps2 996bc3d
HUDProvider updates
ps2 c32cd8c
Fix hud clearing after removing pump manager. Show boluses that take …
ps2 76c8f26
PumpManager returns DoseEntry for requested bolus, including duration
ps2 bdaea1d
Example jumpstart
ps2 b535cfc
Suspend/Resume with new PumpManager status updates
ps2 3a12b02
Fix issue with DeviceDataManager missing from issue report
ps2 b4276a1
Handle LoopKit and rileylink_ios updates
ps2 511f0c2
Cleanup testing code
ps2 fb006e5
Update Loop today widget when HUD views change
ps2 3624d1a
Renaming updates from LoopKit
ps2 8598af6
Updates for recent LoopKit pumpmanager-changes branch
ps2 6a9ce73
update prep script for CGMBLEKit branch change
Kdisimone 0334c23
Merge pull request #12 from ps2/Kdisimone-patch-1
ps2 849916d
Updates for hud provider delegate change
ps2 a7f89ca
Merge branch 'omnikit' of github.com:ps2/loop-priv into omnikit
ps2 8a152ee
Pumpmanager updates
ps2 dd2e2c3
Update prep script
ps2 a18cfb4
Fix permissions on prep workspace script
ps2 2683aa5
Merge in dev
ps2 e22f4b0
Pumpmanager changes
ps2 c0c2242
Update to pumpmanager-updates
ps2 7cff7b4
Back out DEVELOPMENT_TEAM settings
ps2 ebd1e2b
Context object does not need HUDProvider reference
ps2 ba571a7
Include dose in enactBolus completion
ps2 e54617a
Bump dependency revisions
ps2 6a24216
Update HUD set of views only on PumpManager change
ps2 9a6f219
Merge branch 'pumpmanager-changes' of github.com:LoopKit/Loop into pu…
ps2 8a893b6
Remove unused file
ps2 23842de
synchronize deviceDataManager.pumpManagerStatus access
ps2 9a729c6
Bump dep revisions
ps2 509573c
Remove unused files
ps2 26e0ea5
Remove unneeded reloadSections calls
ps2 3e8f83c
Merge branch 'pumpmanager-changes' of github.com:LoopKit/Loop into pu…
ps2 14ae518
Fix build issue when carthage is run from Xcode
ps2 995c3e2
Use bolus end date to clear lastRequestedBolus
ps2 83b1e2e
present instead of show settings vc
ps2 82e66f0
small refactorings
ps2 4f652a8
Improvements from @mpangburn's review
ps2 2985424
Update active flag on HUDProvider when hud is visible and app is active
ps2 be5f843
Remove signing team changes
ps2 9e27c6b
HUDProvider active -> visible
ps2 7f4fd58
Use LoopKit dev
ps2 f8e4f58
Use constant for battery replacement detection threshold
ps2 ee07fcf
Force git protocol 1 to fix travis builds
ps2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,7 @@ | ||
|
|
||
| github "LoopKit/LoopKit" == 2.2.1 | ||
| github "LoopKit/CGMBLEKit" == 3.0 | ||
| github "LoopKit/LoopKit" "dev" | ||
| github "LoopKit/CGMBLEKit" "dev" | ||
| github "i-schuetz/SwiftCharts" == 0.6.2 | ||
| github "LoopKit/dexcom-share-client-swift" == 1.0 | ||
| github "LoopKit/G4ShareSpy" == 1.0 | ||
| github "ps2/rileylink_ios" == 2.1.0 | ||
| github "LoopKit/dexcom-share-client-swift" "dev" | ||
| github "LoopKit/G4ShareSpy" "dev" | ||
| github "ps2/rileylink_ios" "dev" | ||
| github "LoopKit/Amplitude-iOS" "decreepify" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| github "LoopKit/Amplitude-iOS" "2137d5fd44bf630ed33e1e72d7af6d8f8612f270" | ||
| github "LoopKit/CGMBLEKit" "v3.0" | ||
| github "LoopKit/G4ShareSpy" "v1.0" | ||
| github "LoopKit/LoopKit" "v2.2.1" | ||
| github "LoopKit/dexcom-share-client-swift" "v1.0" | ||
| github "LoopKit/CGMBLEKit" "ea1267791c66e884f1013fffd36faf4555cc6eaf" | ||
| github "LoopKit/G4ShareSpy" "fed5a389e3e47e3a1953878dd21852aa5f44b360" | ||
| github "LoopKit/LoopKit" "bf4166bc77f89e22971f2030ad006967881ff082" | ||
| github "LoopKit/dexcom-share-client-swift" "b0419edf55c7f389b36cb47dd5c376bbd3d03d69" | ||
| github "i-schuetz/SwiftCharts" "0.6.2" | ||
| github "ps2/rileylink_ios" "v2.1.0" | ||
| github "ps2/rileylink_ios" "46ed2c845e7c4b88c721994d8e8432e86be4c699" |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // | ||
| // PumpManagerUI.swift | ||
| // Loop | ||
| // | ||
| // Created by Pete Schwamb on 10/18/18. | ||
| // Copyright © 2018 LoopKit Authors. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
| import LoopKit | ||
| import LoopKitUI | ||
| import MinimedKit | ||
| import MinimedKitUI | ||
|
|
||
| private let managersByIdentifier: [String: PumpManagerUI.Type] = allPumpManagers.compactMap{ $0 as? PumpManagerUI.Type}.reduce(into: [:]) { (map, Type) in | ||
| map[Type.managerIdentifier] = Type | ||
| } | ||
|
|
||
| typealias PumpManagerHUDViewsRawValue = [String: Any] | ||
|
|
||
| func PumpManagerHUDViewsFromRawValue(_ rawValue: PumpManagerHUDViewsRawValue) -> [BaseHUDView]? { | ||
| guard let rawState = rawValue["hudProviderViews"] as? HUDProvider.HUDViewsRawState, | ||
| let managerIdentifier = rawValue["managerIdentifier"] as? String, | ||
| let manager = managersByIdentifier[managerIdentifier] | ||
| else { | ||
| return nil | ||
| } | ||
|
|
||
| return manager.createHUDViews(rawValue: rawState) | ||
| } | ||
|
|
||
| func PumpManagerHUDViewsRawValueFromHudProvider(_ hudProvider: HUDProvider) -> PumpManagerHUDViewsRawValue { | ||
| return [ | ||
| "managerIdentifier": hudProvider.managerIdentifier, | ||
| "hudProviderViews": hudProvider.hudViewsRawState | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts regarding making these raw strings as constants to avoid typos and such?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the current pattern of RawRepresentable use in Loop rarely defines constants for raw strings. Probably a good idea to begin that transition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've had typos cause issues while developing. Constants don't completely prevent that (you can still use the wrong constant!), and create more clutter. I'm not opposed to it; I just question if it's really worth it.