Pumpmanager changes #877
Pumpmanager changes #877
Conversation
…mpmanager-changes
…mpmanager-changes
darinkrauss
left a comment
darinkrauss
left a comment
There was a problem hiding this comment.
A few comments/questions, but nothing that blocks approval from my perspective. 🚀
|
|
||
| import LoopKitUI | ||
|
|
||
| public final class GlucoseHUDView: BaseHUDView { |
There was a problem hiding this comment.
Will this be moving over to LoopKit at some point?
| import LoopKitUI | ||
|
|
||
| public class HUDView: UIView, NibLoadable { | ||
| @IBOutlet public weak var loopCompletionHUD: LoopCompletionHUDView! |
There was a problem hiding this comment.
Will these be moving over to LoopKit? Is this a work in progress?
| typealias PumpManagerHUDViewsRawValue = [String: Any] | ||
|
|
||
| func PumpManagerHUDViewsFromRawValue(_ rawValue: PumpManagerHUDViewsRawValue) -> [BaseHUDView]? { | ||
| guard let rawState = rawValue["hudProviderViews"] as? HUDProvider.HUDViewsRawState, |
There was a problem hiding this comment.
What are your thoughts regarding making these raw strings as constants to avoid typos and such?
There was a problem hiding this comment.
Yes, the current pattern of RawRepresentable use in Loop rarely defines constants for raw strings. Probably a good idea to begin that transition.
There was a problem hiding this comment.
Yes, I've had typos cause issues while developing. Constants don't completely prevent that (you can still use the wrong constant!), and create more clutter. I'm not opposed to it; I just question if it's really worth it.
No description provided.