Skip to content

Implement PumpManager protocol #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Implement PumpManager protocol #753

merged 2 commits into from
Jul 5, 2018

Conversation

ps2
Copy link
Collaborator

@ps2 ps2 commented Jun 26, 2018

No description provided.

@Kdisimone
Copy link
Collaborator

There may have been some appreciative tears over here this weekend. thank you for this. Only thing I've noticed, for the basal rates and delivery rate screens, would be nice if any edits are saved when exiting the screen, even if "save to pump" is not selected. Current operation is that making an edit and then backing out of the screen when done (similar to what current fingers would do by muscle memory) results in the edits not being saved (unless save to pump is used). In situations where the "save to pump" fails because of comms issues, the edits also disappear (but that's probably an expected thing? could it be prevented?). thank you again!

@ps2
Copy link
Collaborator Author

ps2 commented Jul 1, 2018

It's intentional that it doesn't save. We don't want to get the two systems to get out of sync. A "track changes and warn before discard" would be a better experience. Needs work.

@Kdisimone
Copy link
Collaborator

Sounds good. I like that option too

@ps2 ps2 merged commit b0602dd into dev Jul 5, 2018
@ps2 ps2 deleted the pump-manager branch September 3, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants