Poll reservoir when sentry listening is unavailable #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, refactoring some device connection assertion code from LoopDataManager to DeviceDataManager Fixes #1
lgruen
pushed a commit
to lgruen/Loop
that referenced
this pull request
Aug 1, 2018
…ion-LoopKit2 Align with Loop updates around LoopKit v2
iMaces
referenced
this pull request
in iMaces/Loop
Aug 23, 2018
Don't send expired overrides in watch context
erikdi
pushed a commit
to erikdi/Loop
that referenced
this pull request
Feb 10, 2019
Allow Xcode warnings in podspec validation for now
ps2
added a commit
that referenced
this pull request
Mar 9, 2019
* Limit recommended temp basals to supported rates. * Use pumpmanager provided rounding * Fix tests, and update to PumpManager function name change * Update naming from review comments
dthornley
pushed a commit
to dthornley/Loop
that referenced
this pull request
Oct 9, 2019
…5f4d96a2bbeef7 parent a4568c4 author Cal Young <cyoung1024@gmail.com> 1565904731 +0200 committer David Thornley <david.thornley@darnt.com> 1570653504 +0200 # This is a combination of 6 commits. # This is the 1st commit message: Add Spike Client and change version # This is the commit message LoopKit#2: Add Spike as CGM source # This is the commit message LoopKit#3: Add Spike frameworks # This is the commit message LoopKit#4: Add Spike to LSApplicationQueriesSchemes # This is the commit message LoopKit#5: Update Cartfile.resolved # This is the commit message LoopKit#6: Add Spike Calibration guide # This is the commit message LoopKit#11: Fixed delay between Spike update and Loop update
Andrei0105
pushed a commit
to Andrei0105/Loop
that referenced
this pull request
Aug 22, 2020
[master] Open loop if there is a jump > 50mg/dl between 2 consecutive readings
jeremybarnum
pushed a commit
to jeremybarnum/Loop
that referenced
this pull request
May 12, 2022
Release FreeAPS v2.2 (201)
ps2
pushed a commit
that referenced
this pull request
Feb 20, 2023
* Add unannounced meal func to CarbStoreProtocol * V1 of UAM algo * Add debug logs * Handle unannounced meal notification & open up controller * Add mealstart to notification userinfo * Improve notification description * Add direct entry to carb flow from notification on watch * Add auto-setting of carb entry on watch * carbThreshold -> mealCarbThreshold * Retract UAM notifications after the carbs have expired * Improve function naming * Move notification logic from LoopKit to Loop * Make current date configurable * Make current date configurable during unit testing * Update status enum naming for point-of-use clarity * Make 'now' time configurable * Extract loop data manager testing logic into base class * Extract loop data manager dosing tests into their own file * Add unannounced meal tests * Fix concurrency issue * Pull UAM constants into separate struct * Fix notifications not being retracted after their expiration date * Expire using start of meal instead of current time * Add unannounced meal notifications permission * Add AlertPermissionsViewModel * Remove unneeded `AnyView`s * Removed unused completion block * Use the counteraction effects passed into the function * Schedule missed meal notifications to avoid notification during an microbolus (#3) * Delay missed meal notification if possible to avoid delivering it during an autobolus * Add tests for notification delay * Update `estimatedDuration` function headers in response to PR feedback * Add UAM banner to carb entry screen (#5) * Add warning banner to remind the user to edit the meal estimate * Update warning text * UAM algo updates: only use directly observed carb absorption (#6) * Add ability to calculate the number of carbs in a missed meal (#4) * Plumb a customizable carb amount through UAM notification architecture * Fix merge conflict * Update tests for changes from the merge * Make UAM notifications unit testable * Add carb autofill clamping based on the user's carb threshold & max bolus * Update target order to group extensions together * Improve issue report description * Create `MealDetectionManager` from old UAM functions in `CarbStore` * Move notification logic into `MealDetectionManager` * Updates based on feedback for UAM PR (#7) * Create `MealDetectionManager` from old UAM functions in `CarbStore` * Move notification logic into `MealDetectionManager` * Move UAM test fixtures from LoopKit to Loop * Remove old TODO * Revert change to Loop signing team * Fix merge issues * Make tests runnable * Lower meal carb threshold to 15 g to reduce false-negatives * Fix carb entry controller merge issues * Unannounced meal / UAM -> missed meal * UAM test fixture -> missed meal test fixture * Variable naming improvements * Remove `AlertPermissionsViewModel` * Move call to check for missed meals to `loop()`-level * Remove `CarbStore` dependency from `MealDetectionManager` These changes also remove the requirement that there be no carbs entered after the missed meal was detected - since we're now observing direct absorption, I didn't think this requirement made sense anymore * Reduce `minRecency` required to detect a meal * Update counteraction effect math in `MealDetectionManager` to skew towards an earlier meal time instead of a later one * Fix conflict + move missed meal toggle 1 level higher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, refactoring some device connection assertion code from
LoopDataManagertoDeviceDataManager.Fixes #1