Skip to content

tidepool-merge: force unwrap to remove Optional in front of two markdown headers #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025

Conversation

marionbarker
Copy link
Contributor

Purpose:

Two of the headers in the Loop Report are printed as optionals, e.g.:

Optional(## WatchDataManager

Optional(## StatusExtensionDataManager

This messes up the syntax and makes it difficult to automatically parse the report.

Approach:

Add a force unwrap to the two lines of code.

Test:

With this change, all the markdown headers are now printed as expected, e.g.:

## WatchDataManager

## StatusExtensionDataManager

@marionbarker marionbarker requested a review from ps2 March 21, 2025 22:53
@marionbarker marionbarker changed the title force unwrap to remove Optional in front of two markdown headers tidepool-merge: force unwrap to remove Optional in front of two markdown headers Apr 3, 2025
Copy link
Collaborator

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marionbarker marionbarker merged commit d0caf2b into LoopKit:tidepool-merge Apr 6, 2025
@marionbarker marionbarker deleted the fix_md_format branch April 6, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants