Temporary overrides 🏃‍♀️🤒 (#18)

* Revamped temporary override mode

* Watch integration, remove remnants of old workout mode

* Update Cartfile

* Update Watch preset selection interface

* removing signing team

* Clear charts override after finishing

* Account for optional target range

* Optional target range updates

* Fix missing comma from merge

* Override history tracking

* Renaming

* Fix StatusTableViewController for overrides

* Backport previous workout mode

* Enable overrides

* Update Watch button label per feature flags

* Feature flags via plist

* Correct workout button enable state in legacy

* Remove recovered references

* Allow overriding of feature flags and build settings.

* Updates from review

* Fix status row presence post-resume

Author: mpangburn

Common/Extensions/GlucoseRangeSchedule.swift

@@ -10,38 +10,8 @@ import HealthKit
 
 
 extension GlucoseRangeSchedule {
-    func overrideEnabledForContext(_ context: Override.Context) -> Bool? {
-        guard let override = override, override.context == context else {
-            guard let value = overrideRanges[context], !value.isZero else {
-                // Unavailable to set
-                return nil
-            }
-
-            return false
-        }
-
-        return override.isActive()
-    }
-
-    var activeOverride: GlucoseRangeSchedule.Override? {
-        guard let override = override, override.isActive() else {
-            return nil
-        }
-
-        return override
-    }
-
-    var activeOverrideContext: GlucoseRangeSchedule.Override.Context? {
-        return activeOverride?.context
-    }
-
-    var configuredOverrideContexts: [GlucoseRangeSchedule.Override.Context] {
-        var contexts: [GlucoseRangeSchedule.Override.Context] = []
-        for (context, range) in overrideRanges where !range.isZero {
-            contexts.append(context)
-        }
-
-        return contexts
+    func minQuantity(at date: Date) -> HKQuantity {
+        return HKQuantity(unit: unit, doubleValue: value(at: date).minValue)
     }
 }
 

Common/FeatureFlags.swift

@@ -0,0 +1,30 @@
+//
+//  FeatureFlags.swift
+//  Loop
+//
+//  Created by Michael Pangburn on 5/19/19.
+//  Copyright © 2019 LoopKit Authors. All rights reserved.
+//
+
+import Foundation
+
+
+let FeatureFlags: FeatureFlagConfiguration = {
+    guard
+        let path = Bundle.main.path(forResource: "FeatureFlags", ofType: "plist"),
+        let data = FileManager.default.contents(atPath: path),
+        let configuration = try? PropertyListDecoder().decode(FeatureFlagConfiguration.self, from: data)
+    else {
+        return FeatureFlagConfiguration()
+    }
+
+    return configuration
+}()
+
+struct FeatureFlagConfiguration: Decodable {
+    let sensitivityOverridesEnabled: Bool
+
+    fileprivate init() {
+        self.sensitivityOverridesEnabled = false
+    }
+}

DoseMathTests/DoseMathTests.swift

@@ -84,7 +84,7 @@ class RecommendTempBasalTests: XCTestCase {
     }
 
     var glucoseTargetRange: GlucoseRangeSchedule {
-        return GlucoseRangeSchedule(unit: HKUnit.milligramsPerDeciliter, dailyItems: [RepeatingScheduleValue(startTime: TimeInterval(0), value: DoubleRange(minValue: 90, maxValue: 120))], overrideRanges: [:])!
+        return GlucoseRangeSchedule(unit: HKUnit.milligramsPerDeciliter, dailyItems: [RepeatingScheduleValue(startTime: TimeInterval(0), value: DoubleRange(minValue: 90, maxValue: 120))])!
     }
 
     var insulinSensitivitySchedule: InsulinSensitivitySchedule {
@@ -120,6 +120,25 @@ class RecommendTempBasalTests: XCTestCase {
         XCTAssertNil(dose)
     }
 
+    func testNoChangeOverrideActive() {
+        let glucose = loadGlucoseValueFixture("recommend_temp_basal_no_change_glucose")
+
+        let dose = glucose.recommendedTempBasal(
+            to: glucoseTargetRange,
+            at: glucose.first!.startDate,
+            suspendThreshold: suspendThreshold.quantity,
+            sensitivity: insulinSensitivitySchedule,
+            model: insulinModel,
+            basalRates: basalRateSchedule,
+            maxBasalRate: maxBasalRate,
+            lastTempBasal: nil,
+            isBasalRateScheduleOverrideActive: true
+        )
+
+        XCTAssertEqual(0.8, dose!.unitsPerHour, accuracy: 1.0 / 40.0)
+        XCTAssertEqual(TimeInterval(minutes: 30), dose!.duration)
+    }
+
     func testStartHighEndInRange() {
         let glucose = loadGlucoseValueFixture("recommend_temp_basal_start_high_end_in_range")
 
@@ -472,7 +491,7 @@ class RecommendBolusTests: XCTestCase {
     }
 
     var glucoseTargetRange: GlucoseRangeSchedule {
-        return GlucoseRangeSchedule(unit: HKUnit.milligramsPerDeciliter, dailyItems: [RepeatingScheduleValue(startTime: TimeInterval(0), value: DoubleRange(minValue: 90, maxValue: 120))], overrideRanges: [:])!
+        return GlucoseRangeSchedule(unit: HKUnit.milligramsPerDeciliter, dailyItems: [RepeatingScheduleValue(startTime: TimeInterval(0), value: DoubleRange(minValue: 90, maxValue: 120))])!
     }
 
     var insulinSensitivitySchedule: InsulinSensitivitySchedule {

Loop.xcconfig

@@ -9,3 +9,7 @@
 // This is automatically disambiguated by development team, but you may choose to change this to
 // support running multiple apps simultaneously.
 MAIN_APP_BUNDLE_IDENTIFIER = com.${DEVELOPMENT_TEAM}.loopkit
+MAIN_APP_DISPLAY_NAME = Loop
+
+// Optional workspace configuration overrides
+#include? "../LoopConfigOverride.xcconfig"