[PAL-172] only display pump manager provided HUD view when there is no status highlight (#607)

nhamming · web-flow · commit 9ccb7dd16042 · 2023-12-01T16:09:19.000-04:00
diff --git a/LoopUI/Views/PumpStatusHUDView.swift b/LoopUI/Views/PumpStatusHUDView.swift
@@ -43,7 +43,7 @@ public final class PumpStatusHUDView: DeviceStatusHUDView, NibLoadable {
     }
 
     override public func presentStatusHighlight() {
-        guard !statusStackView.arrangedSubviews.contains(statusHighlightView) else {
+        guard !isStatusHighlightDisplayed else {
             return
         }
         
@@ -86,7 +86,14 @@ public final class PumpStatusHUDView: DeviceStatusHUDView, NibLoadable {
     
     public func addPumpManagerProvidedHUDView(_ pumpManagerProvidedHUD: BaseHUDView) {
         self.pumpManagerProvidedHUD = pumpManagerProvidedHUD
+        guard !isStatusHighlightDisplayed else {
+            self.pumpManagerProvidedHUD.isHidden = true
+            return
+        }
         statusStackView.addArrangedSubview(self.pumpManagerProvidedHUD)
     }
     
+    private var isStatusHighlightDisplayed: Bool {
+        statusStackView.arrangedSubviews.contains(statusHighlightView)
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public final class PumpStatusHUDView: DeviceStatusHUDView, NibLoadable {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`override public func presentStatusHighlight() {`
`46`		`- guard !statusStackView.arrangedSubviews.contains(statusHighlightView) else {`
	`46`	`+ guard !isStatusHighlightDisplayed else {`
`47`	`47`	`return`
`48`	`48`	`}`
`49`	`49`
`@@ -86,7 +86,14 @@ public final class PumpStatusHUDView: DeviceStatusHUDView, NibLoadable {`
`86`	`86`
`87`	`87`	`public func addPumpManagerProvidedHUDView(_ pumpManagerProvidedHUD: BaseHUDView) {`
`88`	`88`	`self.pumpManagerProvidedHUD = pumpManagerProvidedHUD`
	`89`	`+ guard !isStatusHighlightDisplayed else {`
	`90`	`+ self.pumpManagerProvidedHUD.isHidden = true`
	`91`	`+ return`
	`92`	`+ }`
`89`	`93`	`statusStackView.addArrangedSubview(self.pumpManagerProvidedHUD)`
`90`	`94`	`}`
`91`	`95`
	`96`	`+ private var isStatusHighlightDisplayed: Bool {`
	`97`	`+ statusStackView.arrangedSubviews.contains(statusHighlightView)`
	`98`	`+ }`
`92`	`99`	`}`