Skip to content

Commit 0a3a165

Browse files
authored
Configure the version number in LoopWorkspace, not Loop (#2303)
* Configure the version number in LoopWorkspace, not Loop * enable VersionOveride to be placed in LoopWorkspace * report the LoopWorkspace branch in Settings * reorder search for version override, add note about version for DIY Loop
1 parent 760174b commit 0a3a165

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

Loop/Managers/SupportManager.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ extension SupportManager: SupportUIDelegate {
227227
}
228228

229229
private var branchNameIfNotReleaseBranch: String? {
230-
return BuildDetails.default.gitBranch.filter { branch in
230+
return BuildDetails.default.workspaceGitBranch.filter { branch in
231231
return branch != "" &&
232232
branch != "main" &&
233233
branch != "master" &&

Version.xcconfig

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,11 @@
66
// Copyright © 2020 LoopKit Authors. All rights reserved.
77
//
88

9-
// Version [DEFAULT]
10-
LOOP_MARKETING_VERSION = 3.5.0
11-
CURRENT_PROJECT_VERSION = 57
9+
// Version
10+
// [for DIY Loop] configure the version number in LoopWorkspace
11+
LOOP_MARKETING_VERSION = 1.0
12+
CURRENT_PROJECT_VERSION = 1
1213

13-
// Optional override
14+
// Optional override (enables override of version)
15+
#include? "../VersionOverride.xcconfig"
1416
#include? "VersionOverride.xcconfig"

0 commit comments

Comments
 (0)