Update G7SensorKit tidepool-merge with improvements from main #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found myself missing the 'Open app' button from the G6, and that my muscle memory kept expecting it to be there, so in this PR I've added it into the G7 management screen. I opted to create a new section rather than include it with the other management buttons beneath to try to prevent users accidentally tapping the more destructive actions.
Add link to Dexcom app in G7 settings
Add Dexcom One+ to allowed prefix
* enable use of environment appName * restore comment to original * modify text with appName so translation string remains constant * update Xcode placement of Bundle.swift, fix typo in header
* Continue with sensor even after auth without control msg * Add handling for failed sensor, and add more logs * Add additional failure types * Handle possible new state of session ended * Additional logs * Check for connection event, for cases where iOS fails to call didDiscover * Use remote disconnect without auth/data as end-of-session detection again.
Add build dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Bring in improvements added to the main branch since the tidepool-merge branch was first pushed to LoopKit
Test
Start with a local clone using LoopWorkspace
tidepool-mergebranch:Confirmed that G7 CGM can be selected but do not actually connect to a sensor.