Skip to content

Conversation

@lachlangrose
Copy link
Member

This pull request removes outdated configuration files and Dockerfiles, introduces a new FaultTopology class for managing fault relationships, and enhances the StratigraphicColumn class with observable functionality and additional methods for managing stratigraphic units and relationships. It also includes minor code cleanup and logging improvements.

Removal of legacy files:

  • .flake8: Removed the file, which previously set max line length and ignored specific warnings.
  • Dockerfile and DockerfileDev: Removed both files, which contained outdated configurations for building Docker images. [1] [2]

New FaultTopology class:

  • LoopStructural/modelling/core/fault_topology.py: Added the FaultTopology class to represent fault relationships and their interactions with stratigraphic units. It includes methods for adding, updating, and querying fault relationships and stratigraphy-fault relationships.

Enhancements to StratigraphicColumn:

  • LoopStructural/modelling/core/stratigraphic_column.py:
    • Made StratigraphicColumn an observable class, enabling notifications for changes like adding or removing units, updating order, and clearing the column. [1] [2] [3] [4] [5] [6] [7]
    • Added methods for retrieving group-unit pairs and finding groups for specific unit names. [1] [2]

Code cleanup and logging improvements:

@lachlangrose lachlangrose merged commit ea4b9f0 into master Jul 30, 2025
17 checks passed
@lachlangrose lachlangrose deleted the fix/add-observer branch July 30, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants