Address code review comments: fix validation, spelling, scope, and mutable defaults

Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

Author: Copilot

LoopStructural/interpolators/_discrete_interpolator.py

@@ -63,7 +63,7 @@ def __init__(self, support, data={}, c=None, up_to_date=False):
         logger.info("Creating discrete interpolator with {} degrees of freedom".format(self.dof))
         self.type = InterpolatorType.BASE_DISCRETE
         self.apply_scaling_matrix = True
-        self.add_ridge_regulatisation = True
+        self.add_ridge_regularisation = True
         self.ridge_factor = 1e-8
     def set_nelements(self, nelements: int) -> int:
         return self.support.set_nelements(nelements)
@@ -588,7 +588,7 @@ def solve_system(
         self,
         solver: Optional[Union[Callable[[sparse.csr_matrix, np.ndarray], np.ndarray], str]] = None,
         tol: Optional[float] = None,
-        solver_kwargs: dict = {},
+        solver_kwargs: dict = None,
     ) -> bool:
         """
         Main entry point to run the solver and update the node value
@@ -608,15 +608,18 @@ def solve_system(
             True if the interpolation is run
 
         """
+        if solver_kwargs is None:
+            solver_kwargs = {}
         if not self._pre_solve():
             raise ValueError("Pre solve failed")
 
+        S = None  # Initialize scaling matrix
         A, b = self.build_matrix()
-        if self.add_ridge_regulatisation:
+        if self.add_ridge_regularisation:
             ridge = sparse.eye(A.shape[1]) * self.ridge_factor
             A = sparse.vstack([A, ridge])
             b = np.hstack([b, np.zeros(A.shape[1])])
-            logger.info("Adding ridge regularisation to interpolation matrix")
+            logger.info("Adding ridge regularization to interpolation matrix")
         if self.apply_scaling_matrix:
             S = self.compute_column_scaling_matrix(A)
             A = A @ S
@@ -650,9 +653,6 @@ def solve_system(
 
         elif solver == 'lsmr':
             logger.info("Solving using lsmr")
-            # if 'atol' not in solver_kwargs:
-            #     if tol is not None:
-            #         solver_kwargs['atol'] = tol
             if 'btol' not in solver_kwargs:
                 if tol is not None:
                     solver_kwargs['btol'] = tol
@@ -718,7 +718,11 @@ def solve_system(
         # self._post_solve()
         # apply scaling matrix to solution
         if self.apply_scaling_matrix:
-            self.c = S @ self.c
+            if S is None:
+                logger.error("Scaling matrix S is not defined; skipping scaling of solution.")
+                self.up_to_date = False
+            else:
+                self.c = S @ self.c
         return self.up_to_date
 
     def update(self) -> bool:

LoopStructural/modelling/features/builders/_fault_builder.py

@@ -141,13 +141,12 @@ def fault_normal_vector(self, v):
         if v is None:
             self._fault_normal_vector = None
         else:
-            if len(v.shape) != 1 or v.shape[0] != 3:
-                raise ValueError("fault_normal_vector must be a 3 element array")
-            if v.ndim != 1:
-                v = v[0,:]
-            if v.shape[0] != 3:
-                raise ValueError("fault_normal_vector must be a 3 element array")
             arr = np.array(v, dtype=float)
+            # If more than 1D, take the first row and then validate length
+            if arr.ndim > 1:
+                arr = arr[0]
+            if arr.shape[0] != 3:
+                raise ValueError("fault_normal_vector must be a 3 element array")
             norm = np.linalg.norm(arr)
             if norm == 0:
                 raise ValueError("fault_normal_vector cannot be the zero vector")