Skip to content

Conversation

@Nowocyn
Copy link
Contributor

@Nowocyn Nowocyn commented Nov 28, 2023

There was a missing "s" inside of the OpenAPI generatePaths function.

The function tried to match the string 'detail' but it never appeared with the default route names via Rest::resource('users', UsersController::class);

php artisan route:list ->

GET|HEAD  api/v1/users ... api.v1.users.details › App\Rest\Controllers\UsersController@details
  DELETE    api/v1/users ... api.v1.users.destroy › App\Rest\Controllers\UsersController@destroy
  POST      api/v1/users/actions/{action} ... api.v1.users.operate › App\Rest\Controllers\UsersController@operate
  POST      api/v1/users/mutate ... api.v1.users.mutate › App\Rest\Controllers\UsersController@mutate
  POST      api/v1/users/search ... api.v1.users.search › App\Rest\Controllers\UsersController@search

Before fix:
image

After fix:
image

I also added a space after the url inside the rest:documentation command info.

@GautierDele GautierDele merged commit 6f63144 into Lomkit:master Nov 29, 2023
@GautierDele
Copy link
Member

Hello @Nowocyn,

Thanks for your MR, merging !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants