Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility fix for 2019.4.40f1 #371

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

Eideren
Copy link
Contributor

@Eideren Eideren commented Dec 7, 2022

2019.4.40f1doesn't support static local functions, nor inactive optional argument for UnityEngine.Object.FindObjectsOfType.
I'm not sure what helper surfaces are, so not even sure that my change would work in this context - let me know.

Small note, there's a ton of mixed whitespace in files, we may want to do something about that.

@nukeandbeans
Copy link
Collaborator

Helper surfaces are the meshes that get used to display debug information in the scene through the dropdown @ the right of the bottom toolbar.

The whitespaces thing is something I've been wanting to fix, but there is a lot of whitespaces to change, and would need a thorough check to make sure they wouldn't break anything (if done with automation, e.g. file > format). It'd have to be a PR of its own.

I tracked down where the local method changes came from, and the changes were from https://github.com/Kerfuffles/realtime-CSG-for-unity/pull/1/files
It seems I disregarded changing them back to older compatibility, but I guess I hadn't checked that version to make sure it worked with it. Thanks for the fixes!

@nukeandbeans nukeandbeans merged commit ea6619a into LogicalError:master Dec 8, 2022
FriskTheFallenHuman pushed a commit to FriskTheFallenHuman/RealtimeCSG that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants