Omnibus PR with fixes for #333, #334, #335, and README updates #340
Conversation
… is moved from Assets/Plugins a data generator was used to create EmbeddedAssets. To update any icons should the need arise, one would just simply run the generator again to update it. (see Icon2EmbeddedAssetUtility). Icon2EmbeddedAssetUtility should(tm) find the correct folder automatically when generating icons. All one needs to do is place the icons in the Resources/Icons folder
…realtime-CSG-for-unity into remove-unity-project
…nore meta for readme, etc
…enerating RP materials. instead of using the shader name to generate folders, it now uses URP and HDRP respectively (based on the default shader present in the RP) when creating RP materials, to reduce folder structure depth. additionally, RCSG now uses an assembly definition, which is used to locate RCSG when locating assets.
…, fix player build issue
|
Sorry made some tiny modifications to 2 files, didn't notice your PR until after that |
No worries! I'll just bring the changes over when I have time. |
|
All merge conflicts were resolved. If all is good, then I'll go ahead and merge the changes + create a release. |
Some paths were hardcoded to use `Assets/`. This fixes that, and should now function identically from `Assets/` or `Packages/`
fixed some wording that was incorrect
|
Just occurred to me that there should probably be a FAQs section in the readme. I'll add that in after work later today. Beyond that, that is all the things I can think of that needed fixing or adding, unless someone else brings something up. |
|
Trying this PR in an actual project seems to cause an extended load time, that seems to go on infinitely (freezes the editor basically). I'm looking into changing how |
|
Farther digging provides that the hang is related to render pipelines and material generation. Looking into how to fix this. |
|
Last commit should hopefully fix the aforementioned material generation issue and allow RCSG to work with RPs properly, again. |
This PR fixes issues introduced with PR #333. It fixes #334 and closes #335. All changes that were not present in the release 7521cd7 and were in #333 are here, as well.
Changes introduced in #333:
#333 fixes introduced in this PR:
RealtimeCSG.asmdefor a text document.#334 and #335 fixes:
UNITY_EDITORdefine was added to the define constraints ofRealtimeCSG.asmdef, and compatible platforms were defined, which fixes player builds failing due to editor classes included in build.Other changes: