Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X and Z axes transposed when creating a Box? #323

Closed
DavidAntliff opened this issue May 7, 2021 · 2 comments · Fixed by #349
Closed

X and Z axes transposed when creating a Box? #323

DavidAntliff opened this issue May 7, 2021 · 2 comments · Fixed by #349
Assignees
@nukeandbeans
Labels
Bug Fix available

Comments

@DavidAntliff
Copy link

DavidAntliff commented May 7, 2021 •
edited
Loading

I'm very new to realtime-CSG so apologies if this has already been reported, or I've missed something.

When I go to create a Box using the Generate menu, and manually type values into the Height, Length and Width fields, the axis that the rectangle changes does not match the label on the field.

Specifically, the "Length (X)" field seems to set the dimension in the local Z axis.
The "Width (Z)" field seems to set the dimension in the local X axis.

For example, if I create a box with Height 0.1, Length 1.0 and Width 0.5, then it ends up creating a "brush" with the local Y axis height of 0.1, but local X axis of 0.5, and local Z axis of 1.0.

It's as if the X and Z axes are transposed.

I'm using v1.562.
nukeandbeans pushed a commit to nukeandbeans/realtime-CSG-for-unity that referenced this issue Apr 14, 2022
@kerfuffles
fix LogicalError#323
24ba831
@nukeandbeans nukeandbeans mentioned this issue Apr 14, 2022
Merged
@nukeandbeans
Copy link
Collaborator

This issue is caused by Scripts/View/GUI/EditModeGUI/EditModes/Generators/Generator.Box.GUI, where generator.Length and generator.Width seemed to have gotten mixed up with each other and used in the wrong double field.

This will be fixed when #349 gets merged.

@nukeandbeans nukeandbeans self-assigned this May 8, 2022
@Janooba
Copy link
Contributor

Janooba commented Jun 13, 2022

Confirmed fixed in #349 using 2019.4.31f1

Zallist pushed a commit to Zallist/realtime-CSG-for-unity that referenced this issue Sep 23, 2022
@kerfuffles @Zallist
fix LogicalError#323
f06f7ed
nukeandbeans pushed a commit that referenced this issue Nov 6, 2022
@kerfuffles
MSC Bug Fixes (#349)
e07c919 
Co-authored-by: Zallist <Zallist@gmail.com>
Co-authored-by: Gawi <95928592+Gawidev@users.noreply.github.com>

* Update Window.mat and Window.png to support proper transparency and specularity.
* Fixes #323 
* Fixes #355
* Fixes #350 
* Fixes #319 
* Fixes #320
* Fixes #354 
* Fixes #356 
* Fixes #365 
* Fixes #366
FriskTheFallenHuman pushed a commit to FriskTheFallenHuman/RealtimeCSG that referenced this issue Jan 30, 2023
@kerfuffles @FriskTheFallenHuman
MSC Bug Fixes (LogicalError#349)
4a969ef 
Co-authored-by: Zallist <Zallist@gmail.com>
Co-authored-by: Gawi <95928592+Gawidev@users.noreply.github.com>

* Update Window.mat and Window.png to support proper transparency and specularity.
* Fixes LogicalError#323
* Fixes LogicalError#355
* Fixes LogicalError#350
* Fixes LogicalError#319
* Fixes LogicalError#320
* Fixes LogicalError#354
* Fixes LogicalError#356
* Fixes LogicalError#365
* Fixes LogicalError#366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nukeandbeans nukeandbeans

Labels
Bug Fix available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MSC Bug Fixes nukeandbeans/realtime-CSG-for-unity
3 participants
@nukeandbeans @DavidAntliff @Janooba