This repository was archived by the owner on Dec 14, 2023. It is now read-only.
Hide member variables in LogentriesServlet; use SLF4J #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHynes7
pushed a commit
that referenced
this pull request
May 11, 2015
Hide member variables in LogentriesServlet; use SLF4J
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@StephenHynes7 sorry I missed this for so long- generally LGTM but since we've ditched mobius internally, the if/dbg logic should probably be left to the logging implementation. Also changed the
startedflag to an AtomicBoolean as it's one of those things that's good to idiot-proof. Also we don't use K&R style that much in Java code but don't want to cause trouble. Nice work!