Fix example in readme which doesn't handle no children #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lodin
requested changes
Jul 24, 2021
| @@ -72,7 +72,7 @@ const treeNodes = [ | |||
| const getNodeData = (node, nestingLevel) => ({ | |||
| data: { | |||
| id: node.id.toString(), // mandatory | |||
| isLeaf: node.children.length === 0, | |||
| isLeaf: !!node.children, | |||
There was a problem hiding this comment.
I guess, it should be reversed: a leaf element is an element without children. For the documentation purposes, I suggest using a more explicit check:
Suggested change
| isLeaf: !!node.children, | |
| isLeaf: node.children == null || node.children.length === 0, |
| @@ -95,6 +95,8 @@ function* treeWalker() { | |||
| // the `getNodeData` function constructed, so you can read any data from it. | |||
| const parent = yield; | |||
|
|
|||
| if (!parent.node.children) continue | |||
There was a problem hiding this comment.
Why you are using continue outside of for loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the FixedSizeTree example in the readme doesn't work because it expects all nodes to have children which they don't. Wasn't sure though if if the right solution was to give all leaf nodes an empty children array, or to just handle no children array. Thoughts?