-
Notifications
You must be signed in to change notification settings - Fork 9
Minutes
Taras Mankovski edited this page Jul 21, 2016
·
2 revisions
PR by Zach and Albert:
- https://github.com/LocusEnergy/ember-sparkles/pull/3
- Add Pie chart to ember-sparkles
- ember-sparkles - has helpers that shouldn't be there: map, log-debug
- log-debug
- should be replaced with r/log helper in ember-reactive-helpers
- map
- Taras created PR to ember-composable-helpers with map, filter & reduce
- Once Merged https://github.com/DockYard/ember-composable-helpers/pull/185 we should use these helpers and remove it from ember-sparkles
- log-debug
- ember-reactive-helpers
- Ember reactive helpers has an r helper, to get the function from a helper and curries the arguments.
- Figure out 'fix
too late
transition error'- Only happens when you're making animations.
- If you cause transitions really quickly.
- Possible solution: We have a way to reference the previous transition, we could make the helper check if the past transition was an action, then cancel it.
- Taras will look at this
- Ivan updated ember-cli-d3-shape to use d3 directly
- Ivan mentioned an issue that Mike North opened about ember-d3
- https://github.com/brzpegasus/ember-d3/issues/4
- We might want to consider either merging ember-d3 with ember-cli-d3-shape or rename ember-cli-d3-shape to ember-cli-d3-shim
- Here is a proposal issue https://github.com/ivanvanderbyl/ember-cli-d3-shape/issues/22
- Ivan showed a helper that he created to create paths with rounded corners
- Could be good to make part of ember-d3-helpers
- Ivan has D3 donut graph in maximum-plaid
- We need to be able to add tooltips to the graph without tooltips being hardcoded into the donut graph
- Taras created ember-dnd-helpers:
- Helpers for drag and drop using mostly pure Ember
- Ivan:
- Next time we should discuss merging maximum-plaid and ember-sparkles Zach:
- I've been trying to work on the contextual pattern, which cleans things all.
- The error is about applying transition to an objet already in transition.
- We probably need to check if the point is in the appropriate place.
- Squash PR commits
- Zach will work on the axis stuff
- Bulding an admin panel: there's a couple of panels, but might not be useful.