diff --git a/mesonbuild/build.py b/mesonbuild/build.py index 3ff68ed1f7c8..fac0c4203e16 100644 --- a/mesonbuild/build.py +++ b/mesonbuild/build.py @@ -380,6 +380,7 @@ def __init__(self, name, subdir, subproject, is_cross, sources, objects, environ self.process_compilers_late() self.validate_sources() self.validate_cross_install(environment) + self.check_module_linking() def __lt__(self, other): return self.get_id() < other.get_id() @@ -1027,6 +1028,13 @@ def get_using_msvc(self): def is_linkable_target(self): return False + def check_module_linking(self): + ''' + Warn if shared modules are linked with target: (link_with) #2865 + ''' + for link_target in self.link_targets: + if isinstance(link_target, SharedModule): + mlog.warning('''Linking shared modules to targets is not recommended''') class Generator: def __init__(self, args, kwargs): diff --git a/run_unittests.py b/run_unittests.py index 6ab549c0c0ac..65ededf7bbed 100755 --- a/run_unittests.py +++ b/run_unittests.py @@ -1897,6 +1897,17 @@ def test_flock(self): exception_raised = True self.assertTrue(exception_raised, 'Double locking did not raise exception.') + def test_check_module_linking(self): + ''' + Test that shared modules are not linked with targets(link_with:) #2865 + ''' + tdir = os.path.join(self.unit_test_dir, '25 shared_mod linking') + out = self.init(tdir) + for expected in [ + r'WARNING: Linking shared modules to targets is not recommended' + ]: + self.assertRegex(out, re.escape(expected)) + def test_ndebug_if_release_disabled(self): testdir = os.path.join(self.unit_test_dir, '25 ndebug if-release') self.init(testdir, extra_args=['--buildtype=release', '-Db_ndebug=if-release']) diff --git a/test cases/unit/25 shared_mod linking/installed_files.txt b/test cases/unit/25 shared_mod linking/installed_files.txt new file mode 100644 index 000000000000..c7dab9f6f510 --- /dev/null +++ b/test cases/unit/25 shared_mod linking/installed_files.txt @@ -0,0 +1 @@ +usr/bin/prog?exe diff --git a/test cases/unit/25 shared_mod linking/libfile.c b/test cases/unit/25 shared_mod linking/libfile.c new file mode 100644 index 000000000000..44f7667d4ff4 --- /dev/null +++ b/test cases/unit/25 shared_mod linking/libfile.c @@ -0,0 +1,14 @@ +#if defined _WIN32 || defined __CYGWIN__ + #define DLL_PUBLIC __declspec(dllexport) +#else + #if defined __GNUC__ + #define DLL_PUBLIC __attribute__ ((visibility("default"))) + #else + #pragma message ("Compiler does not support symbol visibility.") + #define DLL_PUBLIC + #endif +#endif + +int DLL_PUBLIC func() { + return 0; +} diff --git a/test cases/unit/25 shared_mod linking/main.c b/test cases/unit/25 shared_mod linking/main.c new file mode 100644 index 000000000000..12f9c984b976 --- /dev/null +++ b/test cases/unit/25 shared_mod linking/main.c @@ -0,0 +1,11 @@ +#if defined _WIN32 || defined __CYGWIN__ + #define DLL_IMPORT __declspec(dllimport) +#else + #define DLL_IMPORT +#endif + +int DLL_IMPORT func(); + +int main(int argc, char **arg) { + return func(); +} diff --git a/test cases/unit/25 shared_mod linking/meson.build b/test cases/unit/25 shared_mod linking/meson.build new file mode 100644 index 000000000000..d8934e948489 --- /dev/null +++ b/test cases/unit/25 shared_mod linking/meson.build @@ -0,0 +1,6 @@ +project('shared library linking test', 'c', 'cpp') + +lib = shared_module('mylib', + 'libfile.c' # Split to different lines before and after the comma to test parser. + , install : false) # Don't install libraries in common tests; the path is platform-specific +exe = executable('prog', 'main.c', link_with : lib, install : true) \ No newline at end of file