Skip to content

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Nov 7, 2025

Description

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher force-pushed the feat/FFmpeg/compile-libva-dependency branch 12 times, most recently from eb3ff6c to 0b25d62 Compare November 8, 2025 03:27
@stephank
Copy link

I can't seem to reproduce the failiure in a VM when building libva separately, but maybe there's something specific about the cmake environment. Does it hurt to try with --disable-dependency-tracking as suggested?

@ReenigneArcher
Copy link
Member Author

@stephank thanks for looking into this! Was your VM amd64 or aarch64? The build does work in amd64, only fails on aarch64.

I am not really sure the effects of --disable-dependency-tracking, but I can try it. Also as a workaround I think we can look for a system installed version and if it's new enough then skip compiling ourselves. I believe the package for FreeBSD is already new enough.

@stephank
Copy link

I tried on aarch64 with FreeBSD 14.3. The host is a MacBook Air M3.

Dependency tracking is just makefile smarts to help during development, so it knows what file changes affect which compilation units. (Like modifying some C header file affects a whole bunch of C source files.) It's not useful for packaging purposes / single builds.

I'm not sure what to make of it either, and it does feel like a failure in dependency tracking of all things could be something silly (like a shell incompatibility or something) that may surface again later even if we skip dependency tracking now. Shot in the dark; would've liked to see config.log.

Your option to check a system install sounds good too. I have no stake in FreeBSD support. Was just hoping to help move this along. 😄

Removes unused LIBVA_MAKE_ENV variable and adds --disable-dependency-tracking for FreeBSD to address make/gmake compatibility. Also includes libva-wayland.a in the build outputs.
Updated the CI workflow to use rsync instead of sshfs for synchronization. This may improve reliability and performance during file transfers in the CI process.
@ReenigneArcher ReenigneArcher force-pushed the feat/FFmpeg/compile-libva-dependency branch from 7bd22d2 to 8dc5a1b Compare November 17, 2025 21:07
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants