Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom HTML markup #94

Closed
kronos-999 opened this issue Jul 1, 2023 · 2 comments
Closed

Enable custom HTML markup #94

kronos-999 opened this issue Jul 1, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@kronos-999
Copy link

Hello, since we are trying to become a better shuffle.dev, I was thinking of a couple ideas. One of them (among importing markup from cdn servers to enable truly custom code to enter) was to have a live HTML Editor for the markup. A smal JS editor on the side could also be a possibility

@LiveDuo
Copy link
Owner

LiveDuo commented Jul 1, 2023

Hey @kronos-999,

That's an idea that I have long toy with and was requested many times in various forms from community members:

  1. How to add another component #55
  2. Custom components #1
  3. React components #72

I think custom HTML components is the more simple option.

  • These components need to be stored somewhere in the user' repository (maybe in the data folder) so they are persistent across refreshes.
  • The custom HTML components won't have a preview image as that is not generated on the fly.

A custom HTML editor is not compatitble with the current form of the Craft.js version. That's because it uses React and stores the components in a json file. In other words, during development, there is no HTML to edit. In the Grapes.js version there is HTML and an HTML editor which if you haven't already might be worth giving a try.

@LiveDuo LiveDuo added the enhancement New feature or request label Jul 1, 2023
@LiveDuo LiveDuo changed the title [idea] Enable custom markup Enable custom HTML markup Jul 1, 2023
@LiveDuo
Copy link
Owner

LiveDuo commented Mar 13, 2024

@kronos-999 Version 3 is out now and it's now easy to edit the component HTML. You can either edit it in your browser DevTools or edit the template file directly that now uses HTML.

@LiveDuo LiveDuo closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants