Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridArea<std::shared_ptr<LevelChunk>>::move related crash #146

Closed
wcdfilll opened this issue Dec 29, 2021 · 45 comments
Closed

GridArea<std::shared_ptr<LevelChunk>>::move related crash #146

wcdfilll opened this issue Dec 29, 2021 · 45 comments
Labels
bug Related to software malfunction

Comments

@wcdfilll
Copy link

wcdfilll commented Dec 29, 2021

image
i only have an image about bug, it isn't feedback error anything. What I want to ask is, what could it be due to? Port, Plugin or something ? I need to narrow down the error so that I can judge and fix it completely. If it is difficult to judge the error, I will provide more pictures

@wcdfilll wcdfilll added the bug Related to software malfunction label Dec 29, 2021
@KawaiiNahida
Copy link
Member

Every time you execute the command "/home go" BDS will crash immediately?

@wcdfilll
Copy link
Author

wcdfilll commented Dec 29, 2021

that's not it, even if it's not home add or del, it's still interrupted unexpectedly. I can send the file server over to have a better view

@KawaiiNahida
Copy link
Member

Can you use a debugger(x64dbg, windbg, VS) or enable the builtin CrashLogger?

@KawaiiNahida
Copy link
Member

We have no idea What Happened, and we have tested that "/home go" command won't make the server crash

@wcdfilll
Copy link
Author

no, it's not due to /home, I'm sure it is. I keep it open for a while, and let it hang and then it shuts off on its own. The strange thing is, the player's data (each player's item inventory) does not lose any items. Sometimes they even get duplicate items.

@wcdfilll
Copy link
Author

Can you use a debugger(x64dbg, windbg, VS) or enable the builtin CrashLogger?

if this can respond to an error I will send it to you as soon as possible.

@dreamguxiang
Copy link
Member

LL2.0.4?

@wcdfilll
Copy link
Author

yes

@wcdfilll
Copy link
Author

wcdfilll commented Dec 29, 2021

Can you use a debugger(x64dbg, windbg, VS) or enable the builtin CrashLogger?

image
this is the error after i enable crash logger

@wcdfilll
Copy link
Author

I have modified LLhelper's config again.

@dreamguxiang
Copy link
Member

Determined the problem

@dreamguxiang
Copy link
Member

dreamguxiang commented Dec 29, 2021

There is a problem with lltpa, we will update the new version as soon as possible

@wcdfilll
Copy link
Author

Determined the problem

but it also has LxL 's fault

@dreamguxiang
Copy link
Member

The problem has been fixed, please update lless 2.0.4,
https://github.com/LiteLDev/LiteLoaderPlugins/releases/tag/2.0.4

@wcdfilll
Copy link
Author

2.0.4.1:
image

@wcdfilll
Copy link
Author

wcdfilll commented Dec 29, 2021

still same error, I will update the error checking information as soon as possible to fix it

@dreamguxiang
Copy link
Member

What did the player do before the server crash

@dreamguxiang
Copy link
Member

What did the player do before the server crash

Do you know, or what instructions were executed

@wcdfilll
Copy link
Author

What did the player do before the server crash

Do you know, or what instructions were executed

This is the last log file I have. Since there were 15 or more people, I couldn't check them al
CrashDump_20211225_23-20-11.zip
l

@dreamguxiang
Copy link
Member

Is your lltpa version is 211229?There is a person who has the same crash log as you, and it has been resolved

@wcdfilll
Copy link
Author

CrashDump_20211225_23-20-11.zip
tpa has a version, where can I see it? 211229 ?

@dreamguxiang
Copy link
Member

/plugins

@wcdfilll
Copy link
Author

I have updated to the latest

@wcdfilll
Copy link
Author

I can't try again right now, I'll update again tomorrow

@dreamguxiang
Copy link
Member

dreamguxiang commented Dec 29, 2021

211229 mainly fixes the crash of the player's no death to use /back.Its crash log is the same as yours.If it can't be solved, it may be due to internal reasons in bds, or there is an error in the data of a player.

@wcdfilll
Copy link
Author

wcdfilll commented Dec 29, 2021

So how do you fix it? I add LLtpa but not /back ever, but /tpa often. I don't expect a single player on my map with the wrong data to cause the server to crash

@dreamguxiang
Copy link
Member

My friend and I tried all the features of lltpa, but found no bugs, including offline detection of tpa player.If you have the conditions, you can try to run a test server to find a better way to reproduce.The generated crash log, it is completely impossible to see why the place crashed.Except for Level::tick of ll and lxl HOOK, there is no plug-in related information.The method of reproduction is very important, otherwise no one can confirm the location of the crash.

@dreamguxiang
Copy link
Member

dreamguxiang commented Dec 29, 2021

I can tell you a few characteristics,

  1. After the player join the server, the server crashes
  2. The player client crashes,
  3. The server feigned death and then crashed

We have asked other people, if they have the same problem, allows us to solve it faster

If it's just a case, we may not be able to solve it, because my BDS without plugins loader has also crashed and suspended animation.

@dreamguxiang
Copy link
Member

dreamguxiang commented Dec 29, 2021

I tried the old version of LLtpa again,/back problem did not cause a crash, it would only cause the executing player to get stuck, and rejoin the server to recover.

I also saw a similar crash on Mojira, which is likely to be the cause of BDS itself

@KawaiiNahida
Copy link
Member

I suggect that you can try remove LLHelper and LXL temporary and check if it's Okay, I think that vector<LevelChunk>::resize has a stack overflow issue, which is cause by BDS it's own

@wcdfilll
Copy link
Author

I'm thinking of removing lxl first, but if it's ll helper I'll check them one by one if this still happens

@wcdfilll
Copy link
Author

211229 mainly fixes the crash of the player's no death to use /back.Its crash log is the same as yours.If it can't be solved, it may be due to internal reasons in bds, or there is an error in the data of a player.

image

@wcdfilll
Copy link
Author

It's been 3 hours since I quit LLhelper. No more crash messages

@dreamguxiang
Copy link
Member

It's been 3 hours since I quit LLhelper. No more crash messages

I will check llhelper, wait a minute

@dreamguxiang
Copy link
Member

dreamguxiang commented Dec 30, 2021

image
Did you use this feature? try remove it and see if it still crashed randomly

@wcdfilll
Copy link
Author

After 9h server open, server crashed once more. This time, i forget enable builtin CrashLogger so i haven't picture about bug. LLhelper just a part. I plan remove LxL

@wcdfilll
Copy link
Author

image
bug still take place. haizzz

@dreamguxiang
Copy link
Member

dreamguxiang commented Dec 31, 2021

The only case the same as yours was solved by deleting the data of a certain player, Judging from the crash log, it may be that there is a problem with the pos data of a certain player

@wcdfilll
Copy link
Author

if so this is very difficult, when deleting a player data with 7000 different account id in one server. Is it possible ?

@KawaiiNahida
Copy link
Member

We also recived a lot of report from Chinese Community too, but we never succees in reproducing it. This problem looks wired, most of the dump file and TrackBack show us that this is caused by bds realloc or resize std::vector<std::sharedptr>.
so this might related to bad mcworld or player data which may cause it crashed.
It might also because some plugin hook the level::tick and cause this bug and it seems that this problem doesn't exitst in original bds

@KawaiiNahida KawaiiNahida changed the title Sudden server shutdown error GridArea<std::shared_ptr<LevelChunk>>::move related crash Dec 31, 2021
@LazuliKao
Copy link

LazuliKao commented Dec 31, 2021

I had tested HorionHack half a year ago and tested the CrashServer function
This stack information looks the same.
especially these:GridArea<std: : shared ptr<LevelChunk> >::,ChunkViewSource: : move

it looks like there are hackers on your server.

@dreamguxiang
Copy link
Member

image
You can turn on this option to see if the problem still exist

@dreamguxiang
Copy link
Member

We still think this is a crash caused by someone on your server using Horion's crashserver, and turning on BDS's correct-player-movement can effectively prevent it.

@RimuruChan
Copy link
Member

Is it still happening to your server?

@dreamguxiang
Copy link
Member

If this phenomenon persists, please reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Related to software malfunction
Development

No branches or pull requests

6 participants