Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can a delta client request all updates since some time in the past? #274

Closed
enikao opened this issue May 19, 2024 · 4 comments
Closed

Can a delta client request all updates since some time in the past? #274

enikao opened this issue May 19, 2024 · 4 comments
Labels

Comments

@enikao
Copy link
Contributor

enikao commented May 19, 2024

Some delta clients might be interested in updates that happened during the client's absence, e.g. auto fixer.

Can this client ask the repository to "replay" all deltas since some time in the past?
How would it specify that time?

@enikao enikao added the delta label May 19, 2024
@joswarmer
Copy link
Contributor

To make this useful, the server should that also return a "time" with each other request in the current bulk protocol. Otherwise the client does not have the information to know from which time to ask for delta.

If we support this, it will take away the necessity to return the current nodes when subscribing, because the following scenario will simply work:

  1. Client requests partitions
  2. Client requests full AST for partition P
  3. Server returns chunk for partition P + the "time-marker" TM at which this chunk was taken.
  4. Client subscribes to partition P since TM.

@enikao
Copy link
Contributor Author

enikao commented Jul 5, 2024

Related to #68

@enikao
Copy link
Contributor Author

enikao commented Aug 8, 2024

In #294 / #295, we've decided the repository doesn't need to keep a history. This implies a client cannot request past updates.

This might change once we start thinking about additional APIs for #26

@enikao
Copy link
Contributor Author

enikao commented Aug 9, 2024

Decision: Not for standard delta / bulk API, might be additional API

E.g. #26

@enikao enikao closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants