Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to separate between simple and advanced Bulk API? #203

Open
enikao opened this issue Oct 20, 2023 · 3 comments
Open

How to separate between simple and advanced Bulk API? #203

enikao opened this issue Oct 20, 2023 · 3 comments
Labels

Comments

@enikao
Copy link
Contributor

enikao commented Oct 20, 2023

We want to have both a simple (#127) and a complex (#39) query API. How to delineate them?

The simple bulk API should not need knowledge of the metamodel, i.e. languages, for both repository and client implementations.
We can traverse the model tree/forest in the simple API.

Assume we wanted to "find all instances of MetaPointer x" (with x describing a classifier). Then we have to know the metamodel, as we also want to find instances of sub-x with sub-x extends x.

@ftomassetti
Copy link
Contributor

Should we call them language-agnostic and language-aware?

@joswarmer
Copy link
Contributor

I think that for the bulk API the repository should not have to know the languages, but it could (optional).
We can use the same API with a toggle to indicate that the repository should or should not use language information.

This raises a question: a store() call can be refused if the chunk is invalid. A chunk might be valid when the language is not known and be invalid when the language is known. Assuming that a repository knows te he languages involved, who decides that the chunk to be stored is validated against the languages or not, the client or the repository?.

If the client decides this, we might have multiple clients using the repo with and without validation against the languages. This can result in clients that use the repository with language validation to receive (language)incorrect chunks, which is probably unexpected.

@enikao
Copy link
Contributor Author

enikao commented Mar 23, 2024

relates to #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants