-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add trpc protocol support #254
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
pkg/runner/trpc.go
Outdated
rr.EndTime = time.Now() | ||
rr.Error = err | ||
rr.API = testcase.Request.API | ||
rr.Method = "gRPC" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here may be tRPC
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Good catch.
hi @Ink-33 , I made some changes related to the |
There are 21 test cases:
|
SonarCloud Quality Gate failed.
|
* chore(deps): update sonatype/nexus3 docker tag to v3.58.1 * Update app version --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-action update-app-version <githubaction@githubaction.com>
see also trpc-group/trpc-go#100
Below is the test process:
run in the server side:
run the client side:
The binary file (in Linux) will increase 9M size once this PR merged. The old size is 30M. I belive that it's necessary to move the
tRPC
into an extension instead of the core.See the screenshots: