Skip to content

Parse non byte aligned number #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 1, 2023
Merged

Parse non byte aligned number #17

merged 14 commits into from
Aug 1, 2023

Conversation

Murmele
Copy link
Contributor

@Murmele Murmele commented Feb 16, 2023 •
edited
Loading

@Murmele Murmele force-pushed the parseNonByteAlignedNumber branch from 19d3e04 to 2f50209 Compare February 16, 2023 16:57
@LinuxDevon
Copy link
Owner

@Murmele do you need this in the release before I make it?

@Murmele
Copy link
Contributor Author

Murmele commented Jul 27, 2023

Yes please :)

@Murmele
Copy link
Contributor Author

Murmele commented Jul 27, 2023 •
edited
Loading

I will rebase it, then you can merge it. I will let you know when I am ready.
Thank you!

Murmele added 13 commits July 28, 2023 22:47
@Murmele
Description:Add testcase
3f2a88a
@Murmele
Wrong CANid used
6908fb9
@Murmele
Implement 2 complement to decimal
1e7c7a7
@Murmele
add comment
a83a448
@Murmele
Add test
9fc66dc
@Murmele
Fix test
9a347c9 
Reason: When shifting to the left, but the number of bits is not 64, the shift will not shift enough so bits of the next byte might be also in v. With this masking they can be removed
@Murmele
Implement more performant algorithm to get value for little endian
71cac35
@Murmele
add possibility to get the name of the message
4b43b62
@Murmele
Make function const
f4a8a81
@Murmele
Do not install headers if they are not desired.
a3ca54d 
Reason: When including the project with FetchContent into a cmake project the headers are just needed for building, so the headers are not needed to be installed. In this case ignore them
@Murmele
Use FetchContent_Populate
85a4292 
Reason: With it the source can be included directly and it does not install the header files
@Murmele
exclude als cmake files
abe7bae
@Murmele
add missing include. Otherwise tumbleweed does not build anymore
0de0d34
@Murmele Murmele force-pushed the parseNonByteAlignedNumber branch from ca69d0d to 0de0d34 Compare July 29, 2023 13:02
@Murmele Murmele marked this pull request as ready for review July 30, 2023 09:09
@Murmele
Copy link
Contributor Author

Murmele commented Jul 30, 2023

I tested with labplot and it looks good! Thanks for merging!

LinuxDevon
LinuxDevon approved these changes Aug 1, 2023
View reviewed changes
Copy link
Owner

@LinuxDevon LinuxDevon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the work here! Appologize for the delay again. I think the release flow is broken so I will just give it a tag for now and work on an official release when I get some time and motivation.

@LinuxDevon LinuxDevon merged commit 0f3b22b into LinuxDevon:master Aug 1, 2023
@Murmele
Copy link
Contributor Author

Murmele commented Aug 2, 2023

@LinuxDevon don't worry. Thanks for merging! I will update in Labplot to your release 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxDevon LinuxDevon LinuxDevon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Murmele @LinuxDevon