Skip to content

Commit 4aafcc7

Browse files
committed
Change FROM container to Ubuntu, correct needed apt-get packages, correct build process on shippable, improve make file labels
1 parent 78cb0a1 commit 4aafcc7

File tree

3 files changed

+29
-27
lines changed

3 files changed

+29
-27
lines changed

Dockerfile

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM htmlgraphic/ssh:latest
1+
FROM ubuntu:16.04
22
MAINTAINER Jason Gegere <jason@htmlgraphic.com>
33

44
# Install packages then remove cache package list information
@@ -7,6 +7,11 @@ ENV DEBIAN_FRONTEND noninteractive
77
RUN apt-get update && apt-get install -yq --no-install-recommends python-software-properties software-properties-common \
88
apache2 \
99
php7.0 \
10+
cron \
11+
curl \
12+
ghostscript \
13+
mailutils \
14+
iputils-ping \
1015
libapache2-mod-php7.0 \
1116
mysql-client \
1217
php-apcu \
@@ -21,13 +26,14 @@ RUN apt-get update && apt-get install -yq --no-install-recommends python-softwar
2126
php7.0-mbstring \
2227
php7.0-opcache \
2328
php7.0-xml \
24-
ghostscript \
2529
libgs-dev \
2630
imagemagick \
2731
libmagickwand-dev \
32+
language-pack-en \
2833
supervisor \
29-
cron \
3034
rsyslog \
35+
vim \
36+
wget \
3137
postfix && apt-get clean && rm -rf /var/lib/apt/lists/*
3238

3339
# POSTFIX

Makefile

Lines changed: 19 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
# Build a container via the command "make build"
22
# By Jason Gegere <jason@htmlgraphic.com>
33

4-
VERSION = 1.7.1
5-
NAME = apache
4+
TAG = 1.7.1
5+
CONTAINER = apache
66
IMAGE_REPO = htmlgraphic
7-
IMAGE_NAME = $(IMAGE_REPO)/$(NAME)
8-
DOMAIN = htmlgraphic.com
7+
IMAGE_NAME = $(IMAGE_REPO)/$(CONTAINER)
98
include .env # .env file needs to created for this to work properly
109

1110

@@ -14,17 +13,16 @@ all:: help
1413

1514
help:
1615
@echo ""
17-
@echo "-- Help Menu"
16+
@echo "-- Help Menu for $(IMAGE_NAME):$(TAG)"
1817
@echo ""
19-
@echo " make build - Build image $(IMAGE_NAME):$(VERSION)"
20-
@echo " make push - Push $(IMAGE_NAME):$(VERSION) to public docker repo"
18+
@echo " make build - Build Image"
19+
@echo " make push - Push $(IMAGE_NAME):$(TAG) to public Docker repo"
2120
@echo " make run - Run docker-compose and create local development environment"
22-
@echo " make start - Start the EXISTING $(NAME) container"
23-
@echo " make stop - Stop local environment build"
24-
@echo " make restart - Stop and start $(NAME) container"
25-
@echo " make rm - Stop and remove $(NAME) container"
26-
@echo " make state - View state $(NAME) container"
27-
@echo " make logs - View logs in real time"
21+
@echo " make start - Start the EXISTING $(CONTAINER) container"
22+
@echo " make stop - Stop running containers"
23+
@echo " make rm - Stop and remove $(CONTAINER) container"
24+
@echo " make state - View state $(CONTAINER) container"
25+
@echo " make logs - View logs"
2826

2927

3028
env:
@@ -39,11 +37,11 @@ build:
3937
docker build \
4038
--build-arg VCS_REF=`git rev-parse --short HEAD` \
4139
--build-arg BUILD_DATE=`date -u +"%Y-%m-%dT%H:%M:%SZ"` \
42-
--rm -t $(IMAGE_NAME):$(VERSION) -t $(IMAGE_NAME):envoyer .
40+
--rm -t $(IMAGE_NAME):$(TAG) -t $(IMAGE_NAME):latest .
4341

4442
push:
4543
@echo "note: If the repository is set as an automatted build you will NOT be able to push"
46-
docker push $(IMAGE_NAME):$(VERSION)
44+
docker push $(IMAGE_NAME):$(TAG)
4745

4846
run:
4947
@echo 'Checking... initial run structure'
@@ -65,17 +63,15 @@ stop:
6563
@echo "Stopping local environment setup"
6664
docker-compose stop
6765

68-
restart: stop start
69-
7066
rm:
7167
@echo "On remove, containers are specifally referenced, as to not destroy ANY persistent data"
72-
@echo "Removing $(NAME) and $(NAME)_db"
73-
docker rm -f $(NAME)
74-
docker rm -f $(NAME)_db
68+
@echo "Removing $(CONTAINER) and $(CONTAINER)_db"
69+
docker rm -f $(CONTAINER)
70+
docker rm -f $(CONTAINER)_db
7571

7672
state:
77-
docker ps -a | grep $(NAME)
73+
docker ps -a | grep $(CONTAINER)
7874

7975
logs:
80-
@echo "Build $(NAME)..."
81-
docker logs -f $(NAME)
76+
@echo "Build $(CONTAINER)..."
77+
docker logs -f $(CONTAINER)

shippable.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ build:
1313
- make build
1414
pre_ci_boot:
1515
image_name: htmlgraphic/apache
16-
image_tag: $BRANCH
16+
image_tag: latest
1717
pull: false
1818
ci:
1919
- "bash app/run.sh &"

0 commit comments

Comments
 (0)