Fix tool mark disappearing with small tool diameter in g-code preview widget#3741
Fix tool mark disappearing with small tool diameter in g-code preview widget#3741RomSunZ wants to merge 9 commits intoLinuxCNC:masterfrom
Conversation
Tool marker disappears if its diameter less then some value but not equal zero (for example if diameter from tool table is used as wear corrector)
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
Prevent tool mark disappearing with small tool diameter in g-code preview widget
|
I don't think that it makes sense to update the sample configs to have the same value as the default (ie zero). I feel that it should be some appropriate value dependent on the units of the config. Also, the new parameter would need adding to the documentation (docs/src/config/ini-config.adoc) |
I put in ini 0.08 inch for imperial and 2mm for metric. Also I am not familiar with github, should I create additional pull request for documentation or delete this pull request and than create another? |
I think you can just add commits to the branch you PRd and push that, it should update the PR, so just add documentation to this PR. |
Tool marker disappears if its diameter less then some value but not equal zero (for example if diameter from tool table is used as wear corrector)