Skip to content
This repository has been archived by the owner on Aug 5, 2021. It is now read-only.

solidity-coverage fixed to version 0.7.2 #326

Open
elenadimitrova opened this issue May 29, 2020 · 1 comment
Open

solidity-coverage fixed to version 0.7.2 #326

elenadimitrova opened this issue May 29, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@elenadimitrova
Copy link

elenadimitrova commented May 29, 2020

solidity-coverage is pinned to specific version, currently 0.7.2. However the latest version is 0.7.4 which includes some fixes for the support of Solidity 0.6. There are likely to be more upcoming minor fixes and I can't see a reason to not allow it to upgrade with something like "solidity-coverage": "^0.7.2"

Currently with the upgraded repo for argent-contracts we get the following error which might be fixed in 0.7.4

Error: Error: Could not instrument: modules/GuardianManager.sol. (Please verify solc can compile this file without errors.) Unrecognized expression
    at Object.runCoverage (/Users/Elena/Source/argent-contracts/node_modules/etherlime/cli-commands/etherlime-test/etherlime-coverage.js:84:9)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at Function.Module.runMain (internal/modules/cjs/loader.js:744:11)
    at findNodeScript.then.existing (/Users/Elena/.nvm/versions/node/v10.12.0/lib/node_modules/npm/node_modules/libnpx/index.js:268:14)
etherlime coverage [path] [timeout] [port] [solcVersion] [workingDirectory]
[html] [ignoreFiles]
@ochikov
Copy link
Collaborator

ochikov commented May 29, 2020

Thank you. I will fix it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants