Update warpdrive tutorial #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikb11
requested review from
Borda,
ethanwharris,
rohitgr7,
carmocca and
SeanNaren
as code owners
Codecov Report
@@ Coverage Diff @@
## main #172 +/- ##
===================================
Coverage 75% 75%
===================================
Files 2 2
Lines 370 370
===================================
Hits 276 276
Misses 94 94 |
Borda
reviewed
May 17, 2022
Comment on lines
5
to
8
| ! pip uninstall --quiet "torchaudio" "torchvision" "torchtext" "fastai" "datascience" "kapre" --yes | ||
| ! pip install --quiet "rl-warp-drive>=1.6.5" "pytorch-lightning>=1.4" | ||
| else: | ||
| ! pip install --quiet "ipython[notebook]" "rl-warp-drive>=1.6.5" "ffmpeg-python" "setuptools==59.5.0" "torch>=1.8" "torchmetrics>=0.7" "pytorch-lightning>=1.4" |
There was a problem hiding this comment.
this is not valid python, if you have some additional comment on how to install it on different env such as colab, lest add it as text celll
There was a problem hiding this comment.
We could use subprocess.run(..)
There was a problem hiding this comment.
this is not the point, you try to band the system for this specific notebook and specific env of Colab...
Borda
requested changes
May 17, 2022
Comment on lines
5
to
8
| ! pip uninstall --quiet "torchaudio" "torchvision" "torchtext" "fastai" "datascience" "kapre" --yes | ||
| ! pip install --quiet "rl-warp-drive>=1.6.5" "pytorch-lightning>=1.4" | ||
| else: | ||
| ! pip install --quiet "ipython[notebook]" "rl-warp-drive>=1.6.5" "ffmpeg-python" "setuptools==59.5.0" "torch>=1.8" "torchmetrics>=0.7" "pytorch-lightning>=1.4" |
There was a problem hiding this comment.
this is not the point, you try to band the system for this specific notebook and specific env of Colab...
Borda
reviewed
May 17, 2022
Borda
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes # (issue)
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃