-
Notifications
You must be signed in to change notification settings - Fork 80
Add Flash Question Answering tutorial #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flash Question Answering tutorial #125
Conversation
# First, download the data: | ||
|
||
# %% | ||
download_data("https://pl-flash-data.s3.amazonaws.com/kaggle_chaii.zip", DATASET_PATH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move this to meta-file
download_data("https://pl-flash-data.s3.amazonaws.com/kaggle_chaii.zip", DATASET_PATH) |
then we can even skip this cell :]
@karthikrangasai mind checking the failing tests? :] |
…b.com/karthikrangasai/lightning-tutorials into add_flash_tutorial_question_answering
@karthikrangasai could you pls remind me what I have promised here to do to unblock it? 🐰 |
Hello @Borda , We had spoken about
Downloading and sharing the dataset again might have licensing issues. After this, I don't think we had arrived to a conclusive solution. |
acdd659
to
0bb4a7e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
===================================
Coverage 73% 73%
===================================
Files 2 2
Lines 382 382
===================================
Hits 280 280
Misses 102 102 |
just re-generated Key and the same issue, also check that the user approved dataset conditions... need to check deeper |
d4acf6f
to
ac8f7ba
Compare
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃