Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newmetric: ProcrustesDisparity #2723

Merged
merged 27 commits into from
Oct 11, 2024
Merged

Newmetric: ProcrustesDisparity #2723

merged 27 commits into from
Oct 11, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 7, 2024

What does this PR do?

Fixes #2691

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2723.org.readthedocs.build/en/2723/

@SkafteNicki SkafteNicki added this to the v1.5.0 milestone Sep 7, 2024
@SkafteNicki SkafteNicki self-assigned this Sep 7, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 7, 2024
@SkafteNicki SkafteNicki changed the title Newmetric: `ProcrustesDisparity" Newmetric: ProcrustesDisparity Sep 7, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69%. Comparing base (c2c68b6) to head (5069f15).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2723   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         329     334    +5     
  Lines       18086   18152   +66     
======================================
+ Hits        12511   12569   +58     
- Misses       5575    5583    +8     

src/torchmetrics/functional/shape/procrustes.py Outdated Show resolved Hide resolved
src/torchmetrics/functional/shape/procrustes.py Outdated Show resolved Hide resolved
src/torchmetrics/functional/shape/procrustes.py Outdated Show resolved Hide resolved
src/torchmetrics/functional/shape/procrustes.py Outdated Show resolved Hide resolved
src/torchmetrics/shape/procrustes.py Outdated Show resolved Hide resolved
src/torchmetrics/shape/procrustes.py Show resolved Hide resolved
SkafteNicki and others added 4 commits September 14, 2024 09:44
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
@mergify mergify bot added the ready label Sep 16, 2024
@SkafteNicki SkafteNicki enabled auto-merge (squash) October 11, 2024 09:03
@SkafteNicki SkafteNicki merged commit a15ef9a into master Oct 11, 2024
62 checks passed
@SkafteNicki SkafteNicki deleted the newmetric/procrustes branch October 11, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation New metric ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

procrustes alignment
3 participants