Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FeatureShare wrapper on GPU #2348

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Fix FeatureShare wrapper on GPU #2348

merged 5 commits into from
Feb 7, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Feb 3, 2024

What does this PR do?

Fixes #2339
Cached network are not a proper child module and is therefore currently not correctly moved to device.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2348.org.readthedocs.build/en/2348/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Feb 3, 2024
@SkafteNicki SkafteNicki added this to the v1.3.x milestone Feb 3, 2024
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Merging #2348 (183a038) into master (84a6d3f) will decrease coverage by 34%.
The diff coverage is 0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2348     +/-   ##
========================================
- Coverage      69%     35%    -34%     
========================================
  Files         303     303             
  Lines       17058   17059      +1     
========================================
- Hits        11760    5942   -5818     
- Misses       5298   11117   +5819     

@mergify mergify bot added the ready label Feb 6, 2024
@Borda Borda merged commit 6f89034 into master Feb 7, 2024
59 checks passed
@Borda Borda deleted the bugfix/fs_cache branch February 7, 2024 16:23
Borda pushed a commit that referenced this pull request Feb 12, 2024
(cherry picked from commit 6f89034)
Borda pushed a commit that referenced this pull request Feb 12, 2024
(cherry picked from commit 6f89034)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usage consistency on GPU between MetricCollection and FeatureShare
2 participants