Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dependencies of LPIPS metric #2230

Merged
merged 15 commits into from
Nov 25, 2023
Merged

Conversation

tanguymagne
Copy link
Contributor

@tanguymagne tanguymagne commented Nov 21, 2023

What does this PR do?

This PR doesn't solve any issue, as it is a very small fix.

Since #1575, the LPIPS metric does not rely anymore on the third-party package PerceptualSimilarity but now relies on torchvision. The changes were not reflected entirely in the doc and in the tests.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests? --> Not necessary.
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2230.org.readthedocs.build/en/2230/

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not seems to be right, check:

from lpips import LPIPS as LPIPS_reference # noqa: N811

@tanguymagne
Copy link
Contributor Author

I have made the requested changes. I hope I understood correctly what was requested.
I am wondering whether or not it is a problem to have a dependency on the unmaintained third-party package lpips for testing ?

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #2230 (dea4c8e) into master (c35a2fb) will decrease coverage by 47%.
Report is 1 commits behind head on master.
The diff coverage is 67%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2230     +/-   ##
========================================
- Coverage      87%     40%    -47%     
========================================
  Files         293     293             
  Lines       16423   16425      +2     
========================================
- Hits        14278    6641   -7637     
- Misses       2145    9784   +7639     

@SkafteNicki SkafteNicki added this to the v1.2.x milestone Nov 23, 2023
@Borda Borda enabled auto-merge (squash) November 23, 2023 09:15
@mergify mergify bot added the ready label Nov 23, 2023
@Borda Borda merged commit 1b16341 into Lightning-AI:master Nov 25, 2023
70 checks passed
Borda pushed a commit that referenced this pull request Nov 30, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

(cherry picked from commit 1b16341)
Borda pushed a commit that referenced this pull request Dec 1, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

(cherry picked from commit 1b16341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants