-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the dependencies of LPIPS metric #2230
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not seems to be right, check:
from lpips import LPIPS as LPIPS_reference # noqa: N811 |
I have made the requested changes. I hope I understood correctly what was requested. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2230 +/- ##
========================================
- Coverage 87% 40% -47%
========================================
Files 293 293
Lines 16423 16425 +2
========================================
- Hits 14278 6641 -7637
- Misses 2145 9784 +7639 |
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> (cherry picked from commit 1b16341)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> (cherry picked from commit 1b16341)
What does this PR do?
This PR doesn't solve any issue, as it is a very small fix.
Since #1575, the LPIPS metric does not rely anymore on the third-party package PerceptualSimilarity but now relies on torchvision. The changes were not reflected entirely in the doc and in the tests.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2230.org.readthedocs.build/en/2230/