Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregate argument to retrieval metrics #2220

Merged
merged 18 commits into from
Nov 28, 2023
Merged

Add aggregate argument to retrieval metrics #2220

merged 18 commits into from
Nov 28, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 17, 2023

What does this PR do?

Fixes #2187

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2220.org.readthedocs.build/en/2220/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Nov 17, 2023
@SkafteNicki SkafteNicki added this to the v1.3.0 milestone Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #2220 (bb8a198) into master (245ee24) will decrease coverage by 52%.
The diff coverage is 93%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2220     +/-   ##
========================================
- Coverage      87%     35%    -52%     
========================================
  Files         293     293             
  Lines       16437   16465     +28     
========================================
- Hits        14275    5722   -8553     
- Misses       2162   10743   +8581     

@mergify mergify bot removed the has conflicts label Nov 21, 2023
@daturkel
Copy link

Incredible, I didn't realize you were even working on this (I had it on my backlog to take a stab at it). Thank you for your help!

@SkafteNicki
Copy link
Member Author

Incredible, I didn't realize you were even working on this (I had it on my backlog to take a stab at it). Thank you for your help!

You are welcome ! sorry for not informing you that I had already implemented it myself :)

@mergify mergify bot removed the has conflicts label Nov 25, 2023
@mergify mergify bot added the ready label Nov 25, 2023
@SkafteNicki SkafteNicki enabled auto-merge (squash) November 25, 2023 19:05
@Borda Borda disabled auto-merge November 28, 2023 16:01
@Borda Borda enabled auto-merge (squash) November 28, 2023 16:12
@Borda Borda merged commit b07b2a5 into master Nov 28, 2023
61 checks passed
@Borda Borda deleted the retrieval_aggregate branch November 28, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flexible aggregation for retrieval metrics
4 participants