Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metric: Davies bouldin score #2071

Merged
merged 16 commits into from
Sep 15, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 11, 2023

What does this PR do?

Fixes part of #2003

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2071.org.readthedocs.build/en/2071/

@SkafteNicki SkafteNicki added this to the v1.2.0 milestone Sep 11, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation topic: Cluster labels Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #2071 (affe165) into master (9b21108) will decrease coverage by 50%.
Report is 1 commits behind head on master.
The diff coverage is 88%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2071     +/-   ##
========================================
- Coverage      87%     36%    -50%     
========================================
  Files         287     289      +2     
  Lines       16072   16128     +56     
========================================
- Hits        13964    5874   -8090     
- Misses       2108   10254   +8146     

@mergify mergify bot added the ready label Sep 11, 2023
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, seems you are missing docs

@SkafteNicki SkafteNicki enabled auto-merge (squash) September 13, 2023 07:51
@SkafteNicki SkafteNicki merged commit 7611b4c into master Sep 15, 2023
63 of 64 checks passed
@SkafteNicki SkafteNicki deleted the newmetric/davies_bouldin_score branch September 15, 2023 14:19
@SkafteNicki SkafteNicki mentioned this pull request Sep 15, 2023
13 tasks
matsumotosan added a commit to matsumotosan/metrics that referenced this pull request Sep 17, 2023
* implementation

* fix error in other metric

* links + init + utils

* add tests

* changelog

* fix inf

* changelog

* docs
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Sep 19, 2023
* implementation

* fix error in other metric

* links + init + utils

* add tests

* changelog

* fix inf

* changelog

* docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation New metric ready topic: Cluster
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants