Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metric: Adjusted mutual info score #2058

Merged

Conversation

matsumotosan
Copy link
Member

@matsumotosan matsumotosan commented Sep 5, 2023

What does this PR do?

Fixes part of #2003

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2058.org.readthedocs.build/en/2058/

@github-actions github-actions bot added documentation Improvements or additions to documentation topic: Cluster labels Sep 5, 2023
@matsumotosan
Copy link
Member Author

I have yet to implement expected_mutual_info_score as it is quite involved.

@SkafteNicki SkafteNicki mentioned this pull request Sep 4, 2023
13 tasks
@matsumotosan
Copy link
Member Author

@SkafteNicki @Borda CI is failing at "Install Sudo in container". Any idea what this is about?

@Borda
Copy link
Member

Borda commented Sep 14, 2023

@SkafteNicki @Borda CI is failing at "Install Sudo in container". Any idea what this is about?

There is likely Microsoft outage, pls be patient and let's try it later again...

@SkafteNicki SkafteNicki added this to the v1.3.0 milestone Sep 15, 2023
munahaf and others added 5 commits September 17, 2023 21:17
Lightning-AI#2082)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* implementation

* fix error in other metric

* links + init + utils

* add tests

* changelog

* fix inf

* changelog

* docs
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@SkafteNicki SkafteNicki marked this pull request as ready for review September 18, 2023 05:34
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #2058 (8b5da2f) into master (8da841c) will decrease coverage by 50%.
The diff coverage is 95%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2058     +/-   ##
========================================
- Coverage      87%     37%    -50%     
========================================
  Files         291     293      +2     
  Lines       16230   16304     +74     
========================================
- Hits        14111    6039   -8072     
- Misses       2119   10265   +8146     

@Borda Borda enabled auto-merge (squash) September 18, 2023 07:02
@SkafteNicki SkafteNicki modified the milestones: v1.3.0, v1.2.0 Sep 18, 2023
@Borda Borda merged commit c6547bb into Lightning-AI:master Sep 18, 2023
66 checks passed
@mergify mergify bot added the ready label Sep 18, 2023
@matsumotosan matsumotosan deleted the 2003-adjusted-mutual-info-score branch September 18, 2023 08:43
matsumotosan added a commit to matsumotosan/metrics that referenced this pull request Sep 19, 2023
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready topic: Cluster
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants