Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metrics: Homogeneity, Completness, V-Measure #2053

Merged
merged 26 commits into from
Sep 15, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 4, 2023

What does this PR do?

Fixes part of #2003
Added homogeneity, completness and v-measure all in one go as they are highly related.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2053.org.readthedocs.build/en/2053/

@SkafteNicki SkafteNicki added this to the v1.2.0 milestone Sep 4, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation topic: Cluster labels Sep 4, 2023
@SkafteNicki SkafteNicki mentioned this pull request Sep 4, 2023
13 tasks
@SkafteNicki SkafteNicki marked this pull request as ready for review September 6, 2023 10:18
@mergify mergify bot added the has conflicts label Sep 6, 2023
@mergify mergify bot removed the has conflicts label Sep 7, 2023
@mergify mergify bot added the has conflicts label Sep 7, 2023
@mergify mergify bot removed the has conflicts label Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2053 (fecf5f2) into master (6eb874c) will decrease coverage by 50%.
Report is 1 commits behind head on master.
The diff coverage is 92%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2053     +/-   ##
========================================
- Coverage      87%     37%    -50%     
========================================
  Files         289     291      +2     
  Lines       16128   16230    +102     
========================================
- Hits        14017    5968   -8049     
- Misses       2111   10262   +8151     

@mergify mergify bot removed the has conflicts label Sep 11, 2023
CHANGELOG.md Show resolved Hide resolved
@mergify mergify bot added the ready label Sep 11, 2023
SkafteNicki and others added 3 commits September 12, 2023 09:28
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
…s_v_measure.py

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
@Borda Borda enabled auto-merge (squash) September 15, 2023 18:02
@mergify mergify bot removed the has conflicts label Sep 15, 2023
@Borda Borda merged commit 8da841c into master Sep 15, 2023
64 checks passed
@Borda Borda deleted the newmetric/homogeneity branch September 15, 2023 18:59
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Sep 17, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Sep 19, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation New metric ready topic: Cluster
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants