MeanAveragePrecision box and segm at same time
#1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock and
stancld
as code owners
|
Perfect, thanks for this change! |
Co-authored-by: vsuryamurthy <v.sury@fizyr.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1928 +/- ##
========================================
- Coverage 86% 39% -48%
========================================
Files 266 266
Lines 15205 15280 +75
========================================
- Hits 13148 5941 -7207
- Misses 2057 9339 +7282 |
Borda
reviewed
Aug 1, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Borda
approved these changes
Aug 7, 2023
justusschock
approved these changes
Aug 8, 2023
|
@SkafteNicki, mind checking the collision withe the prefix PR? 🦩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1905
Make it possible to extract mean average precision for both box and segmentation input at the same time. This is a larger refactor of the internals of the map metric, but it should make it easier to add support for keypoint detection (#1361) in the future.
I am fairly confident that this does not break backwards compatibility in any way as all original tests are passing without any changes.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--1928.org.readthedocs.build/en/1928/