-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for using metric collection and aggregation metric #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1896 +/- ##
======================================
Coverage 85% 85%
======================================
Files 262 262
Lines 15049 15052 +3
======================================
+ Hits 12798 12801 +3
Misses 2251 2251 |
Borda
approved these changes
Jul 9, 2023
justusschock
approved these changes
Jul 11, 2023
4 tasks
Borda
pushed a commit
that referenced
this pull request
Jul 13, 2023
(cherry picked from commit a448ad3)
Borda
pushed a commit
that referenced
this pull request
Jul 13, 2023
(cherry picked from commit a448ad3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1890
Essentially, if a user provides a single value like
torch(1.0) then the state of
SumMetric,
MeanMetric,
MinMetric,
MaxMetricis the exact same after the first
metric.update` call (sum(1) == mean(1) == max(1) == min(1)). In this case metric collection interprets that these should be in the same compute group, which is wrong.Fixes this by given unique state names
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--1896.org.readthedocs.build/en/1896/