Add Source-Aggregated Signal-to-Distortion Ratio (SA-SDR) #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
quancs
requested review from
lantiga,
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
SkafteNicki
reviewed
Jul 6, 2023
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1882 +/- ##
========================================
- Coverage 85% 52% -33%
========================================
Files 260 260
Lines 14912 14952 +40
========================================
- Hits 12669 7793 -4876
- Misses 2243 7159 +4916 |
|
The make-doctest failed on torchmetrics/classification/group_fairness.py, see https://github.com/Lightning-AI/torchmetrics/actions/runs/5477750676/jobs/9977257361?pr=1882#step:6:593 |
SkafteNicki
approved these changes
Jul 9, 2023
FIxed that issue. There is another issue in docs CI right now, but that should hopefully be fixed on lightning side |
Borda
reviewed
Jul 10, 2023
Borda
reviewed
Jul 10, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Borda
approved these changes
Jul 11, 2023
justusschock
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Source-Aggregated Signal-to-Distortion Ratio (SA-SDR)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--1882.org.readthedocs.build/en/1882/