SRMR: update note and change default parameters #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quancs
changed the title
for more information, see https://pre-commit.ci
quancs
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
Borda
approved these changes
Jul 3, 2023
justusschock
approved these changes
Jul 3, 2023
stancld
approved these changes
Jul 3, 2023
stancld
reviewed
Jul 3, 2023
stancld
reviewed
Jul 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1872 +/- ##
========================================
- Coverage 87% 38% -49%
========================================
Files 259 260 +1
Lines 14677 14908 +231
========================================
- Hits 12808 5642 -7166
- Misses 1869 9266 +7397 |
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add note to warn the users that this metric is experimental, and change the default value of
max_cftoNoneto avoid possible misuse.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--1872.org.readthedocs.build/en/1872/