Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compositional logging with lightning #1761

Merged
merged 24 commits into from
Jun 15, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 6, 2023

What does this PR do?

Fixes #1756
The missing self._forward_cache was messing with the lightning logging.
Additionally, I have extended the integration testing quite a lot to be very specific what is logged when for future reference.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label May 6, 2023
@SkafteNicki SkafteNicki added this to the v1.0.0 milestone May 6, 2023
@SkafteNicki SkafteNicki mentioned this pull request May 10, 2023
4 tasks
@SkafteNicki SkafteNicki marked this pull request as ready for review May 22, 2023 19:06
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #1761 (f393232) into master (d396cda) will decrease coverage by 0%.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1761   +/-   ##
======================================
- Coverage      87%     87%   -0%     
======================================
  Files         254     254           
  Lines       14306   14310    +4     
======================================
  Hits        12513   12513           
- Misses       1793    1797    +4     

@SkafteNicki SkafteNicki enabled auto-merge (squash) May 23, 2023 13:38
@mergify mergify bot added the ready label May 23, 2023
@Borda Borda requested a review from a team May 27, 2023 15:08
@mergify mergify bot removed the has conflicts label May 29, 2023
@mergify mergify bot removed the has conflicts label May 30, 2023
@SkafteNicki SkafteNicki merged commit 181e112 into master Jun 15, 2023
@SkafteNicki SkafteNicki deleted the lightning_logging branch June 15, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompositionalMetric seems not to be logged via self.log(...)
3 participants